feat: add persistent peer id example to helia-101 #532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new example demonstrating how to create a Helia node with a persistent peer ID.
- Introduces
202-persistent-peerexample script with filesystem-backed key persistence - Updates
package.json, test suite, andREADME.mdto include and validate the new example
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| examples/helia-101/test/index.spec.js | Added test for the persistent-peer example output |
| examples/helia-101/package.json | Registered new 202-persistent-peer script |
| examples/helia-101/README.md | Documented the new persistent peer ID example |
| examples/helia-101/202-persisent-peer.js | New example showing how to persist peer ID using FsDatastore |
Comments suppressed due to low confidence (3)
examples/helia-101/202-persisent-peer.js:1
- The filename
202-persisent-peer.jsis misspelled. Rename it to202-persistent-peer.jsto match the script name and README references.
/* eslint-disable no-console */
examples/helia-101/README.md:165
- There's an extra period after the link before
is. Remove or reposition it to improve readability.
The [datastore](https://www.npmjs.com/package/interface-datastore). is used to store Helia and libp2p state, such as IPNS names, MFS root CID, pin metadata, kad-dht routing table, and peer store data including WebRTC certificates.
examples/helia-101/test/index.spec.js:15
- [nitpick] The test only asserts the output prefix. Consider validating that a non-empty or expected peer ID is printed to ensure persistence behavior.
await waitForOutput('Started Helia node with Peer ID:', 'node', [path.resolve(__dirname, '../202-persisent-peer.js')])
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.