Skip to content

Better descriptions for dials that failed due to being for private addresses #96

@aschmahmann

Description

@aschmahmann

I sometimes see failures reported like:

Libp2p connected: failed to dial: failed to dial 12D3KooWBiV3fTZuzSDDgzwcgqBjRTmnbxaDjnKtzcV3K3v9CMHt: no good addresses
* [/ip4/10.157.217.171/tcp/4001] gater disallows connection to peer
* [/ip4/10.157.217.171/udp/4001/webrtc-direct/certhash/uEiBbNSfmxY61I_3HEVKX8-AaUHkP9VfzxNxJBKXaOapllA] gater disallows connection to peer
* [/ip4/10.157.217.171/udp/4001/quic-v1] gater disallows connection to peer
* [/ip4/127.0.0.1/tcp/4001] gater disallows connection to peer
* [/ip4/127.0.0.1/udp/4001/webrtc-direct/certhash/uEiBbNSfmxY61I_3HEVKX8-AaUHkP9VfzxNxJBKXaOapllA] gater disallows connection to peer
* [/ip4/127.0.0.1/udp/4001/quic-v1] gater disallows connection to peer
* [/ip6/::1/tcp/4001] gater disallows connection to peer
* [/ip6/::1/udp/4001/webrtc-direct/certhash/uEiBbNSfmxY61I_3HEVKX8-AaUHkP9VfzxNxJBKXaOapllA] gater disallows connection to peer
* [/ip6/::1/udp/4001/quic-v1] gater disallows connection to peer
* [/ip6/fc00:bbbb:bbbb:bb01:d:0:1d:d9ab/tcp/4001] gater disallows connection to peer
* [/ip6/fc00:bbbb:bbbb:bb01:d:0:1d:d9ab/udp/4001/webrtc-direct/certhash/uEiBbNSfmxY61I_3HEVKX8-AaUHkP9VfzxNxJBKXaOapllA] gater disallows connection to peer
* [/ip6/fc00:bbbb:bbbb:bb01:d:0:1d:d9ab/udp/4001/quic-v1] gater disallows connection to peer

For most users seeing gater disallows connection to peer is probably not particularly helpful. Perhaps it'd be better not to report on these failed private addresses or to pre-filter them and perhaps add an error like 10 private addresses found.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions