style(browserAction): keep open on pin/unpin

lidel · lidel · commit 91990ada59fc · 2019-03-12T13:27:17.000+01:00
In past we closed menu after toggling pin status, but now we have nice
visual toggle switch and other uses of the switch do not close the menu.

To unify the UX pin/unpin will keep the menu open.
diff --git a/add-on/src/popup/browser-action/store.js b/add-on/src/popup/browser-action/store.js
@@ -93,7 +93,6 @@ module.exports = (state, emitter) => {
     }
     state.isPinning = false
     emitter.emit('render')
-    window.close()
   })
 
   emitter.on('unPin', async function unPinCurrentResource () {
@@ -112,7 +111,6 @@ module.exports = (state, emitter) => {
     }
     state.isUnPinning = false
     emitter.emit('render')
-    window.close()
   })
 
   async function handlePinError (errorMessageKey, error) {

Original file line number	Diff line number	Diff line change
`@@ -93,7 +93,6 @@ module.exports = (state, emitter) => {`
`93`	`93`	`}`
`94`	`94`	`state.isPinning = false`
`95`	`95`	`emitter.emit('render')`
`96`		`- window.close()`
`97`	`96`	`})`
`98`	`97`
`99`	`98`	`emitter.on('unPin', async function unPinCurrentResource () {`
`@@ -112,7 +111,6 @@ module.exports = (state, emitter) => {`
`112`	`111`	`}`
`113`	`112`	`state.isUnPinning = false`
`114`	`113`	`emitter.emit('render')`
`115`		`- window.close()`
`116`	`114`	`})`
`117`	`115`
`118`	`116`	`async function handlePinError (errorMessageKey, error) {`