Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support DNSLink resolution #2330

Open
oed opened this issue Feb 14, 2025 · 4 comments
Open

Support DNSLink resolution #2330

oed opened this issue Feb 14, 2025 · 4 comments
Labels
area/screen/explore Issues related to IPLS Explorer screen area/screen/files Issues related to Files screen effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up kind/enhancement A net-new feature or improvement to an existing feature P2 Medium: Good to have, but can wait until someone steps up

Comments

@oed
Copy link

oed commented Feb 14, 2025

Is your feature request related to a problem? Please describe.
Currently the explore feature of the webui supports pasting CIDs to resolve and explore content. However, if I want to explore the content of an ENS name, e.g. joelthor.eth, I need to first find a way to get the CID from ENS (for example, by going to the ens app and looking up the record). Since IPFS supports ENS resolution already, it would be a nice feature to have in the webui.

Describe the solution you'd like
I should be able to enter an ENS name in the search bar and it should resolve to whatever content is set as the contentHash of that domain.

Describe alternatives you've considered
N/A

Additional context
N/A

@oed oed added the need/triage Needs initial labeling and prioritization label Feb 14, 2025
@mansijoshi17
Copy link

@oed Hey, Would love to work on this.

@lidel lidel changed the title Support ENS resolution Support DNSLink resolution Feb 15, 2025
@lidel
Copy link
Member

lidel commented Feb 15, 2025

This is a sensible feature, but not specific to ENS. Applies to all DNSLink websites and IPNS too.

@mansijoshi17 if you want to work on this, a quick tip: on button click check if value is a valid CID. If it is not, or if codec is libp2p-key, then you have mutable name that needs to be resolved to immutable CID. To do so, prefix the value with /ipns/ (/ipns/jthor.eth) and then try to resolve mutable name it to immutable CID via ipfs.resolve RPC API. This way you will support ENS, DNSLink and also IPNS names.

@lidel lidel added exp/novice Someone with a little familiarity can pick up P2 Medium: Good to have, but can wait until someone steps up area/screen/files Issues related to Files screen kind/enhancement A net-new feature or improvement to an existing feature area/screen/explore Issues related to IPLS Explorer screen effort/hours Estimated to take one or several hours and removed need/triage Needs initial labeling and prioritization labels Feb 15, 2025
@mansijoshi17
Copy link

Yes agree it is sensible feature, and I have query regarding that. What if someone have you ENS name then they will be able to see your content on ipfs so there will be no privacy here right.

@oed
Copy link
Author

oed commented Feb 17, 2025

@mansijoshi17 It's already possible to look up any ENS name content by visiting https://<name>.eth.link. So it's not a privacy concern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/screen/explore Issues related to IPLS Explorer screen area/screen/files Issues related to Files screen effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up kind/enhancement A net-new feature or improvement to an existing feature P2 Medium: Good to have, but can wait until someone steps up
Projects
None yet
Development

No branches or pull requests

3 participants