chore: build using docker

murat-dogan · achingbrain · commit a72f0769feaf · 2025-05-06T11:10:48.000+01:00
diff --git a/.github/workflows/build-linux.yml b/.github/workflows/build-linux.yml
@@ -21,33 +21,34 @@ jobs:
         arch: [amd64, arm64, arm]
         platform: [debian, alpine]
         include:
-          # Set baselines per platform
-          - triple: "alpine-linux-musl"
-            platform: alpine
+          # Platform-specific baselines
+          - platform: alpine
+            triple: alpine-linux-musl
             version: 3.16
             libc: musl
             gcc_install: clang lld
             gcc: clang
             gxx: clang++
-          # libc is intentionally not set here, as prebuild-install requires libc to not be set for glibc builds
-          - triple: "linux-gnu"
-            platform: debian
+          - platform: debian
+            triple: linux-gnu
             version: bullseye
-          # Set baselines per architecture
-          - triple_arch: x86_64
+            # libc intentionally not set (prebuild requirement)
+
+          # Arch-specific baselines
+          - arch: amd64
+            triple_arch: x86_64
             node_arch: x64
-            arch: amd64
-          - triple_arch: armv7
+          - arch: arm64
+            triple_arch: aarch64
+            node_arch: arm64
+            flags: -march=armv8-a -fPIC
+          - arch: arm
+            triple_arch: armv7
             node_arch: arm
             triple_postfix: eabihf
-            arch: arm
             flags: -march=armv7-a -mfpu=neon-vfpv4 -mfloat-abi=hard -fPIC
-          - triple_arch: aarch64
-            node_arch: arm64
-            arch: arm64
-            flags: -march=armv8-a -fPIC
-          # Set edge case overrides for specific platform + architecture
-          # also define gcc commands for each architecture
+
+          # Platform + Arch overrides (needed for proper toolchain)
           - arch: amd64
             platform: debian
             gcc_install: gcc g++
@@ -58,11 +59,9 @@ jobs:
             gcc_install: gcc-aarch64-linux-gnu g++-aarch64-linux-gnu
             gcc: aarch64-linux-gnu-gcc
             gxx: aarch64-linux-gnu-g++
-          # debian uses the triple `arm-linux-gnueabihf` instead of alpine's `armv7-alpine-linux-musleabihf`
-          # because of this, we explicitly override triple_arch for debian arm
-          - triple_arch: arm
-            arch: arm
+          - arch: arm
             platform: debian
+            triple_arch: arm
             gcc_install: gcc-arm-linux-gnueabihf g++-arm-linux-gnueabihf
             gcc: arm-linux-gnueabihf-gcc
             gxx: arm-linux-gnueabihf-g++
@@ -74,42 +73,64 @@ jobs:
           echo "This workflow should not be triggered with workflow_dispatch on a branch other than master"
           exit 1
       - uses: actions/checkout@v4
+
       - name: Use Node.js ${{ matrix.node-version }}
         uses: actions/setup-node@v4
         with:
           node-version: ${{ matrix.node-version }}
+
       - name: Install node dependencies
         run: npm install --ignore-scripts
         env:
           CI: true
+
       - if: matrix.arch != 'amd64'
         name: Set up QEMU
         uses: docker/setup-qemu-action@v3
         with:
           platforms: ${{ matrix.arch }}
+
       - name: Install system dependencies
         run: |
           sudo apt update
-          sudo apt install -y podman ninja-build ${{ matrix.gcc_install }}
-      - name: List installed libc
-        run: apt list --installed | grep libc6-dev
-      - name: Build sysroot
-        run: sudo podman build --isolation=chroot -t ndc-buildroot:${{ matrix.platform }}-${{ matrix.arch }} ./build-containers --file Dockerfile.${{ matrix.platform }} --platform linux/${{ matrix.arch }} --build-arg="version=${{ matrix.version }}" --build-arg="node_version=${{ matrix.node-version }}"
-      - name: Mount sysroot
-        id: sysroot
-        run: echo "sysroot=$(sudo podman image mount ndc-buildroot:${{ matrix.platform }}-${{ matrix.arch }})" >> $GITHUB_OUTPUT
+          sudo apt install -y podman
+
+      - name: Prepare build container
+        run: >
+          sudo podman build
+          --isolation=chroot
+          -t ndc-buildroot:${{ matrix.platform }}-${{ matrix.arch }}
+          ./build-containers
+          --file Dockerfile.${{ matrix.platform }}
+          --platform linux/${{ matrix.arch }}
+          --build-arg version=${{ matrix.version }}
+          --build-arg node_version=${{ matrix.node-version }}
+          --build-arg gcc_install="${{ matrix.gcc_install }}"
+
       - name: Build
-        run: sudo --preserve-env=SYSROOT,TRIPLE,COMPILER_FLAGS,LIBC,GCC,GXX,CI,PATH node_modules/.bin/prebuild --arch ${{ matrix.node_arch }} -r napi --backend cmake-js -- --CDCMAKE_TOOLCHAIN_FILE:FILEPATH=./cmake/toolchain/ci.cmake
-        env:
-          SYSROOT: ${{ steps.sysroot.outputs.sysroot }}
-          TRIPLE: ${{ matrix.triple_arch }}-${{ matrix.triple }}${{ matrix.triple_postfix }}
-          COMPILER_FLAGS: ${{ matrix.flags }}
-          LIBC: ${{ matrix.libc }}
-          GCC: ${{ matrix.gcc }}
-          GXX: ${{ matrix.gxx }}
-          CI: true
+        run: |
+          sudo podman run --rm \
+            -e TRIPLE=${{ matrix.triple_arch }}-${{ matrix.triple }}${{ matrix.triple_postfix }} \
+            -e COMPILER_FLAGS="${{ matrix.flags }}" \
+            -e LIBC=${{ matrix.libc }} \
+            -e GCC=${{ matrix.gcc }} \
+            -e GXX=${{ matrix.gxx }} \
+            -e CI=true \
+            -v ${{ github.workspace }}:/usr/app \
+            --platform linux/${{ matrix.arch }} \
+            -w /usr/app \
+            ndc-buildroot:${{ matrix.platform }}-${{ matrix.arch }} \
+            node_modules/.bin/prebuild --arch ${{ matrix.node_arch }} -r napi --backend cmake-js -- --CDCMAKE_TOOLCHAIN_FILE:FILEPATH=./cmake/toolchain/ci.cmake
+
       - name: Test
-        run: sudo podman run --rm -v $(pwd):/usr/app/ -e CI=true --platform linux/${{ matrix.arch }} -t ndc-buildroot:${{ matrix.platform }}-${{ matrix.arch }} npm run test
+        run: >
+          sudo podman run --rm
+          -v ${{ github.workspace }}:/usr/app/
+          -e CI=true
+          --platform linux/${{ matrix.arch }}
+          -t ndc-buildroot:${{ matrix.platform }}-${{ matrix.arch }}
+          npm run test
+
       - name: Upload
         run: sudo --preserve-env=CI,LIBC node_modules/.bin/prebuild --arch ${{ matrix.node_arch }} -r napi --upload -u ${{ secrets.GITHUB_TOKEN }}
         env:
diff --git a/build-containers/Dockerfile.alpine b/build-containers/Dockerfile.alpine
@@ -1,6 +1,24 @@
 ARG version=3.16
 ARG node_version=18
+
+# Accept build args
+ARG gcc_install
+
 FROM node:${node_version}-alpine${version}
-RUN apk add build-base openssl-libs-static openssl-dev
+
+RUN apk add \
+    build-base \
+    git \
+    libc-dev \
+    python3 \
+    make \
+    musl-dev \
+    openssl-libs-static \
+    openssl-dev \
+    cmake \
+    ninja \
+    clang \
+    lld \
+    ${gcc_install}
 
 WORKDIR /usr/app/
diff --git a/build-containers/Dockerfile.debian b/build-containers/Dockerfile.debian
@@ -1,7 +1,17 @@
 ARG version=bullseye
 ARG node_version=18
+
+# Accept build args
+ARG gcc_install
+
 FROM node:${node_version}-${version}
+
 RUN apt update
-RUN apt install -y build-essential libssl-dev
+RUN apt install -y --no-install-recommends \
+    build-essential \
+    libssl-dev \
+    cmake \
+    ninja-build \
+    ${gcc_install}
 
 WORKDIR /usr/app/
