protected methods

Author: gfowley

Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    iqeo-conf (0.0.12)
+    iqeo-conf (0.0.13)
 
 GEM
   remote: https://rubygems.org/

lib/iqeo/configuration.rb

@@ -49,6 +49,10 @@ def self.new_defer_block_for_parent parent, &block
       conf
     end
 
+    attr_accessor :_parent, :_items
+
+    # todo: defaults immediate children Configurations should have _parent updated
+
     def initialize default = nil, &block
       @_items = case
                   when default.kind_of?( HashWithIndifferentAccess ) then default
@@ -86,10 +90,8 @@ def method_missing name, *values, &block
       return _set name, values.first                                  # set item to single value
     end
 
-    attr_accessor :_parent, :_items
-
     def _set key, value
-      # fix: extend parenting for enumerable with configurations at arbitrary depth
+      # todo: extend parenting for enumerable with configurations at arbitrary depth
       case
       when value.kind_of?( Configuration ) then value._parent = self
       when value.kind_of?( Enumerable )    then value.each { |v| v._parent = self if v.kind_of? Configuration }
@@ -119,6 +121,8 @@ def _load file
       _read file.respond_to?(:read) ? file.read : File.read(file)
     end
 
+    # todo: merges should update _parent of any immediate child Configurations
+
     def _merge! other
       @_items.merge! other._items
       self
@@ -128,8 +132,12 @@ def _merge other
       self.dup._merge! other
     end
 
+    # todo: can :_parent= be protected ?
+
+    protected :_parent, :_items, :_items=, :_get, :[], :_set, :[]=
 
   end
 
 end
 
+

spec/configuration_spec.rb

@@ -249,8 +249,8 @@ def nested_configuration_example conf
         conf.alpha.bravo.charlie true
       end.to_not raise_error
       conf.should_not be_nil
-      conf.alpha.bravo._parent.should be conf.alpha
-      conf.alpha._parent.should be conf
+      conf.alpha.bravo.send(:_parent).should be conf.alpha
+      conf.alpha.send(:_parent).should be conf
       conf._parent.should be_nil
     end
 
@@ -261,7 +261,7 @@ def nested_configuration_example conf
         conf.alpha Configuration.new, Configuration.new, Configuration.new
       end.to_not raise_error
       conf.should_not be_nil
-      conf.alpha.each { |child| child._parent.should be conf }
+      conf.alpha.each { |child| child.send(:_parent).should be conf }
       conf._parent.should be_nil
     end
 
@@ -787,36 +787,40 @@ def nested_configuration_example conf
 
   end # mode of usage
 
-  it 'can merge! configurations' do
-    orig = simple_explicit_configuration
-    orig.echo :original1
-    orig.foxtrot :original2
-    other = Configuration.new do
-              foxtrot :overridden
-              hotel :new
-            end
-    conf = orig._merge! other
-    simple_configuration_example conf
-    conf.echo.should be :original1
-    conf.hotel.should be :new
-    conf.foxtrot.should be :overridden
-    conf.should be orig
-  end
+  context 'merge' do
+
+    it 'can update its own configuration' do
+      orig = simple_explicit_configuration
+      orig.echo :original1
+      orig.foxtrot :original2
+      other = Configuration.new do
+                foxtrot :overridden
+                hotel :new
+              end
+      conf = orig._merge! other
+      simple_configuration_example conf
+      conf.echo.should be :original1
+      conf.hotel.should be :new
+      conf.foxtrot.should be :overridden
+      conf.should be orig
+    end
+
+    it 'can create a new configuration' do
+      orig = simple_explicit_configuration
+      orig.echo :original1
+      orig.foxtrot :original2
+      other = Configuration.new do
+                foxtrot :overridden
+                hotel :new
+              end
+      conf = orig._merge other
+      simple_configuration_example conf
+      conf.echo.should be :original1
+      conf.hotel.should be :new
+      conf.foxtrot.should be :overridden
+      conf.should_not be orig
+    end
 
-  it 'can merge configurations' do
-    orig = simple_explicit_configuration
-    orig.echo :original1
-    orig.foxtrot :original2
-    other = Configuration.new do
-              foxtrot :overridden
-              hotel :new
-            end
-    conf = orig._merge other
-    simple_configuration_example conf
-    conf.echo.should be :original1
-    conf.hotel.should be :new
-    conf.foxtrot.should be :overridden
-    conf.should_not be orig
   end
 
 end