support for HashSet in secrecy?

[tessus]

It's currently not possible to use HasHset<SecretString>. How can I use a HashSet?
Is there any chance that support for HashSet is added?

[c-git]

That's an interesting idea. If support is added I think it would be good to use a wrapper so it would be opt in so as not to leak info without cause. Can you share a possible use case for this as right now I can't actually think of one other than loading a set of secretes and not wanting to duplicate them but then how would you know which to use?

The wrapper could take a hash of the incoming secret and then store that hash for later use for calls to get a hash.

[tessus]

Thanks for the reply.

As for the use case... we use tokens in rustypaste to allow sending/deleting paste data to/from the server.

Config struct: https://github.com/orhun/rustypaste/blob/master/src/config.rs#L56
Retrieving tokens: https://github.com/orhun/rustypaste/blob/master/src/config.rs#L156-L212
Auth code: https://github.com/orhun/rustypaste/blob/master/src/auth.rs#L13-L45

[tony-iqlusion]

secrecy bounds on the zeroize::Zeroize trait and there is no impl for such types. Since HashSet stores data non-contiguously on the heap, writing such an impl would require access to its internals, which are in Rust's liballoc.

It might be possible to add it to hashbrown (from which liballoc sources it): https://github.com/rust-lang/hashbrown/

[tessus]

I asked Orhun to comment. He's got a better understanding of Rust... ;-)

[orhun]

That's fair, we might give hashbrown's HashSet a try instead then.