Remove tmp and get to final form of this iteration

Author: islas

.github/workflows/ci.yml

@@ -148,55 +148,6 @@ jobs:
       statuses: write
     name : Test ${{ matrix.testSet.name }} on ${{ matrix.testSet.host }}
 
-  tmp_tests:
-    if : ${{ contains( fromJson('["tmp-tests","all-tests"]'), inputs.test ) || inputs.event_name == 'push' }}
-    name: Temp test
-    runs-on: ubuntu-latest
-    permissions:
-      statuses: write
-    steps:
-
-    # Don't use gh checks as they are woefully underdeveloped as a feature leading
-    # to confusing UI and misplaced metrics
-    # https://github.com/orgs/community/discussions/24616
-    - name: Set pending status
-      id: check_run_start
-      uses: actions/github-script@v7
-      with:
-        github-token: ${{ secrets.GITHUB_TOKEN }}
-        script: |
-          github.rest.repos.createCommitStatus({
-            owner:      context.repo.owner,
-            repo:       context.repo.repo,
-            sha:        context.sha,
-            target_url: '${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}',
-            description: 'dummy',
-            context:     '${{ inputs.test }}',
-            state:      'pending'
-          })
-
-    - name: dummy
-      id: dummy
-      run: |
-        echo "Hello World!"
-        sleep 5
-    
-    - name: Set completed status
-      uses: actions/github-script@v7
-      with:
-        github-token: ${{ secrets.GITHUB_TOKEN }}
-        script: |
-          github.rest.repos.createCommitStatus({
-            owner:        context.repo.owner,
-            repo:         context.repo.repo,
-            sha:          context.sha,
-            target_url:   '${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}',
-            description:  'dummy',
-            context:      '${{ inputs.test }}',
-            state:        '${{ contains( fromJson('["success","failure","error"]'),steps.dummy.outcome ) && steps.dummy.outcome || 'error' }}'
-          })
-
-
 
   # # In the event that 'all-tests' is used, this final job will be the one to remove
   # # the label from the PR

.github/workflows/entry_point.yml

@@ -10,14 +10,6 @@ on:
 # https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#pull-request-events-for-forked-repositories-2
   pull_request:
     types:    [ labeled ]
-
-# https://docs.github.com/en/actions/sharing-automations/reusing-workflows#supported-keywords-for-jobs-that-call-a-reusable-workflow
-# Also https://stackoverflow.com/a/74959635
-# TL;DR - For public repositories the safest approach will be to use the default read permissions, but at the cost
-# of not being able to modify the labels. That will need to be a separate [trusted] workflow that runs from the base repo
-# permissions :
-#   contents : read
-#   pull-requests : write
 
 # Write our tests out this way for easier legibility
 # testsSet    :
@@ -30,7 +22,7 @@ on:
 # https://stackoverflow.com/a/68940067
 jobs:
   queue_tests:
-    if : ${{ contains( fromJson('["compile-tests","all-tests","tmp-tests"]'), github.event.label.name ) || github.event_name == 'push' }}
+    if : ${{ contains( fromJson('["compile-tests","all-tests"]'), github.event.label.name ) || github.event_name == 'push' }}
     name: Queue Test (${{ github.event_name == 'push' && github.ref_name || github.event.label.name }})
     runs-on: ubuntu-latest
     permissions:

.github/workflows/test_workflow.yml

@@ -169,6 +169,7 @@ jobs:
         include-hidden-files: true
 
     - name: Set completed status
+      if: ${{ always() }}
       uses: actions/github-script@v7
       with:
         github-token: ${{ secrets.GITHUB_TOKEN }}