Merge pull request #353 from pauc/refactor/commands.build

refactor(commands.build): Run 'before-build' hook before validations.

Author: alexblom

lib/commands/build.js

@@ -130,8 +130,8 @@ module.exports = Command.extend({
 
     logger.info('ember-cordova: Building app');
 
-    return this.startValidators(project, options)
-      .then(hook.prepare('beforeBuild', options))
+    return hook.run('beforeBuild', options)
+      .then(this.startValidators.bind(this, project, options))
       .then(function() {
         if (options.skipEmberBuild !== true) {
           return emberBuild.run();

node-tests/unit/commands/build-test.js

@@ -108,10 +108,10 @@ describe('Build Command', function() {
         .then(function() {
           //h-t ember-electron for the pattern
           expect(tasks).to.deep.equal([
+            'hook beforeBuild',
             'validate-root-url',
             'validate-allow-navigation',
             'validate-platform',
-            'hook beforeBuild',
             'ember-build',
             'cordova-build',
             'hook afterBuild',
@@ -127,10 +127,10 @@ describe('Build Command', function() {
         .then(function() {
           //h-t ember-electron for the pattern
           expect(tasks).to.deep.equal([
+            'hook beforeBuild',
             'validate-root-url',
             'validate-allow-navigation',
             'validate-platform',
-            'hook beforeBuild',
             'cordova-build',
             'hook afterBuild',
             'lint-index'
@@ -145,9 +145,9 @@ describe('Build Command', function() {
         .then(function() {
           //h-t ember-electron for the pattern
           expect(tasks).to.deep.equal([
+            'hook beforeBuild',
             'validate-root-url',
             'validate-allow-navigation',
-            'hook beforeBuild',
             'ember-build',
             'hook afterBuild',
             'lint-index'