Skip to content

Commit 920e501

Browse files
committed
feat(cli): rename skip-ember-build to skip-framework-build
1 parent a5ef28f commit 920e501

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

lib/commands/build.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ module.exports = Command.extend({
2525
{ name: 'build-config', type: 'Path', aliases: ['buildConfig'] },
2626
{ name: 'force', type: Boolean, default: false },
2727
{ name: 'skip-cordova-build', type: Boolean, default: false, aliases: ['scb']},
28-
{ name: 'skip-ember-build', type: Boolean, default: false, aliases: ['seb']},
28+
{ name: 'skip-framework-build', type: Boolean, default: false, aliases: ['sfb'] },
2929

3030
// iOS Signing Options
3131
{ name: 'code-sign-identity', type: String },
@@ -81,7 +81,7 @@ module.exports = Command.extend({
8181
.then(() => framework.validateBuild(options))
8282
.then(() => cordovaTarget.validateBuild(options.skipCordovaBuild))
8383
.then(() => {
84-
if (options.skipEmberBuild !== true) {
84+
if (options.skipFrameworkBuild !== true) {
8585
return framework.build(options).then(() => addCordovaJS.run());
8686
}
8787
})

lib/commands/serve.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ module.exports = Command.extend({
3434
{ name: 'ssl-key', type: String, default: 'ssl/server.key' },
3535
{ name: 'ssl-cert', type: String, default: 'ssl/server.crt' },
3636
{ name: 'force', type: Boolean, default: false },
37-
{ name: 'skip-ember-build', type: Boolean, default: false, aliases: ['seb'] },
37+
{ name: 'skip-framework-build', type: Boolean, default: false, aliases: ['sfb'] },
3838
{ name: 'skip-cordova-build', type: Boolean, default: false, aliases: ['scb'] }
3939
],
4040
/* eslint-enable max-len */
@@ -87,7 +87,7 @@ module.exports = Command.extend({
8787
})
8888
.then(hook.prepare('afterBuild', opts))
8989
.then(function() {
90-
if (opts.skipEmberBuild !== true) {
90+
if (opts.skipFrameworkBuild !== true) {
9191
return framework.serve(opts, ui);
9292
}
9393
})

node-tests/unit/commands/build-test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ describe('Build Command', function() {
112112

113113
it('skips ember-build with the --skip-ember-build flag', function() {
114114
let build = setupBuild();
115-
baseOpts.skipEmberBuild = true;
115+
baseOpts.skipFrameworkBuild = true;
116116

117117
return build.run(baseOpts)
118118
.then(function() {

node-tests/unit/commands/serve-test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ describe('Serve Command', function() {
143143

144144
it('skips emer & cordova builds with --skip flags', function() {
145145
return serveCmd.run({
146-
skipEmberBuild: true,
146+
skipFrameworkBuild: true,
147147
skipCordovaBuild: true
148148
}).then(function() {
149149
expect(tasks).to.deep.equal([

0 commit comments

Comments
 (0)