tests(get-platform): test for getPlatform and subsequent changes

Author: alexblom

lib/commands/open.js

@@ -1,6 +1,7 @@
 'use strict';
 
-var OpenAppTask = require('../tasks/open-app');
+var OpenAppTask     = require('../tasks/open-app');
+var getPlatform     = require('../utils/get-platform');
 
 module.exports = {
   name: 'cordova:open',
@@ -15,9 +16,11 @@ module.exports = {
   ],
 
   run: function(options) {
+    var platform = getPlatform(this.project.config(), options);
+
     var open = new OpenAppTask({
       application: options.application,
-      platform: options.platform,
+      platform: platform,
       project: this.project,
       ui: this.ui
     });

lib/utils/get-platform.js

@@ -1,7 +1,7 @@
 module.exports = function getPlatform(config, options) {
   var platform, defaultPlatform;
-  defaultPlatform = config.cordova && config.cordova.platform;
-  defaultPlatform? platform = defaultPlatform : platform = options.platform;
+  defaultPlatform = config && config.cordova && config.cordova.platform;
+  defaultPlatform ? platform = defaultPlatform : platform = options.platform;
 
   return platform;
 }

node-tests/fixtures/ember-cordova-mock/project.js

@@ -7,10 +7,15 @@ module.exports = {
   env: 'development',
   id: 'ember-cordova-mock',
   name: 'ember-cordova-mock',
-  platform: 'ios',
+  cordova: {
+    platform: 'ios'
+  },
 
   project: {
     root: path.resolve(__dirname, '..', '..', 'fixtures', 'ember-cordova-mock')
   },
+
+  config: function() {},
+
   ui: new MockUI()
 }

node-tests/unit/commands/build-test.js

@@ -89,11 +89,11 @@ describe('Build Command', () => {
     it('passes platform to cordova build task', () => {
       let passedPlatform = 'ios';
 
-      runBuild({
+      return runBuild({
         platform: passedPlatform
+      }).then(function() {
+        expect(cordovaPlatform).to.equal(passedPlatform);
       });
-
-      expect(cordovaPlatform).to.equal(passedPlatform);
     });
   });
 

node-tests/unit/tasks/open-app-test.js

@@ -7,8 +7,8 @@ const OpenAppTask   = require('../../../lib/tasks/open-app');
 const expect        = require('../../helpers/expect');
 const openCommand   = require('../../../lib/utils/open-app-command');
 
-
 const mockProject   = require('../../fixtures/ember-cordova-mock/project');
+const _merge         = require('lodash').merge;
 const isObject      = td.matchers.isA(Object);
 
 describe('Open App Task', () => {
@@ -22,7 +22,7 @@ describe('Open App Task', () => {
       'ember-cordova-mock/ember-cordova/cordova'
     );
 
-    openApp = new OpenAppTask(mockProject);
+    openApp = new OpenAppTask(_merge(mockProject, { platform: 'ios' }));
   });
 
   afterEach(() => {

node-tests/unit/utils/get-platform-test.js

@@ -0,0 +1,20 @@
+'use strict';
+
+const expect        = require('../../helpers/expect');
+const getPlatform   = require('../../../lib/utils/get-platform');
+const mockProject   = require('../../fixtures/ember-cordova-mock/project');
+
+describe('Get Platform Util', () => {
+  it('returns the default platform if one is set', function() {
+    expect(
+      getPlatform(mockProject)
+    ).to.equal('ios');
+  });
+
+  it('returns the cflag platform is there is no default', function() {
+    expect(
+      getPlatform({}, {platform: 'android'})
+    ).to.equal('android');
+  });
+});
+