-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[enchancement] would be great if patches were applied after a full launch #2522
Comments
Either I don't understand how to apply these patches, need more examples of how to do it correctly. |
This is a reasonable request however it is actually quite difficult to implement. The image startup script exec's off to mc-server-runner which runs the server java process and intercepts exit signals. It's that java server process, such as Paper, that initially creates the stock config files. So, it would mostly involve an enhancement to mc-server-runner to add health check logic, check when the java server process is fully up and running, stop the server/container, and allow the container startup script to re-run with the patch invocation. And it needs to only do that the first time. |
BTW, if you haven't seen it already, here is the docs section with an example One solution, to avoid the chicken-and-egg problem, is to make use of the |
It would be great if patches were applied after a full launch, so you could change for example paper-global.yml to link server with proxy.
The text was updated successfully, but these errors were encountered: