Add Cleanroom

[TheMade4]

Enhancement Type

New server type

Describe the enhancement

It would be great to add a new server like Cleanroom (https://github.com/CleanroomMC/Cleanroom), it's a Forge fork, for Minecraft 1.12.2. It can run on Java version 21+.

[itzg]

Thanks, I'll add that to the queue.

In the meantime you might be able to set FORGE_INSTALLER_URL to point to their installer artifact in GitHub:

https://docker-minecraft-server.readthedocs.io/en/latest/types-and-platforms/server-types/forge/

[bbf]

Clean room doesn't seem to follow SEMVER, and it seems to crash the helper's expectation:

[init] Resolving type given FORGE
[mc-image-helper] 16:26:27.096 ERROR : 'install-forge' command failed. Version is 1.39.1
me.itzg.helpers.errors.GenericException: Unexpected format of id from Forge installer's version.json: cleanroom-0.2.3-alpha
     at me.itzg.helpers.forge.ProvidedInstallerResolver.lambda$extractVersion$0(ProvidedInstallerResolver.java:60)
     at me.itzg.helpers.files.IoStreams.readFileFromZip(IoStreams.java:29)
     at me.itzg.helpers.forge.ProvidedInstallerResolver.extractVersion(ProvidedInstallerResolver.java:52)
     at me.itzg.helpers.forge.ProvidedInstallerResolver.resolve(ProvidedInstallerResolver.java:26)
     at me.itzg.helpers.forge.ForgeInstaller.install(ForgeInstaller.java:58)
     at me.itzg.helpers.forge.InstallForgeCommand.call(InstallForgeCommand.java:103)
     at me.itzg.helpers.forge.InstallForgeCommand.call(InstallForgeCommand.java:19)
     at picocli.CommandLine.executeUserObject(CommandLine.java:2045)
     at picocli.CommandLine.access$1500(CommandLine.java:148)
     at picocli.CommandLine$RunLast.executeUserObjectOfLastSubcommandWithSameParent(CommandLine.java:2465)
     at picocli.CommandLine$RunLast.handle(CommandLine.java:2457)
     at picocli.CommandLine$RunLast.handle(CommandLine.java:2419)
     at picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.java:2277)
     at picocli.CommandLine$RunLast.execute(CommandLine.java:2421)
     at picocli.CommandLine.execute(CommandLine.java:2174)
     at me.itzg.helpers.McImageHelper.main(McImageHelper.java:159)
[init] ERROR failed to install Forge given installer /modpacks/cleanroom-0.2.3-alpha-installer.jar

[itzg]

Thanks for testing out the theory @bbf

[itzg]

I finally got around to looking at this more. The version identifier "cleanroom-0.2.3-alpha" is not fully complete since Forge installers normally convey the Minecraft version as part of the identifier, such as "1.20.2-forge-48.1.0". It's important to identify the Minecraft version, so I'll have to think more about how to solve this unless CleanRoom fixes their identifier.

[itzg]

...looking more at version.json, I could leverage

    "inheritsFrom": "1.12.2",

I confirmed that is also present in Forge installer's version.json.