Skip to content
This repository was archived by the owner on Jul 3, 2023. It is now read-only.
This repository was archived by the owner on Jul 3, 2023. It is now read-only.

Incorrect deprecation warning for pingaccess_pingfederate_runtime resource #147

@mosersil

Description

@mosersil

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform Version

Affected Resource(s)

  • resource_pingaccess_pingfederate_runtime

Terraform Configuration Files

resource "pingaccess_pingfederate_runtime" "pf_runtime" {
  targets                      = var.mypingfeds
  audit_level                  = "ON"
  skip_hostname_verification   = false
  use_slo                      = false
  trusted_certificate_group_id = 1
  use_proxy                    = false
  application {
    primary_virtual_host_id = 1
    additional_virtual_host_ids = [ 2 ]
    case_sensitive = true
    context_root = "/"
  }
  back_channel_secure = true
  availability_profile_id      = 1
  load_balancing_strategy_id   = 1
}

Debug Output

Panic Output

Expected Behavior

PF runtime should be configured without any warning

Actual Behavior

We are getting the following warning:

Warning: Argument is deprecated

with pingaccess_pingfederate_runtime.pf_runtime,
on system.tf line 2, in resource "pingaccess_pingfederate_runtime" "pf_runtime":
2: targets = var.mypingfeds

This is the deprecated pingfederate runtime configuration and is only to provide support for 5.x. If you are using 6.x please use 'issuer'
configuration instead.

Since PA allows to configure a PingAccess proxied PF runtime, this should in my view not trigger a deprecation warning anymore.
Not really a severe bug, but would be nice to clean that up.

Steps to Reproduce

  1. terraform plan
  2. terraform apply
  3. terraform plan

Important Factoids

References

  • #0000

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions