Skip to content

Commit 09fb5ff

Browse files
committed
BENCH: remove triple run of mmread/mmwrite benchmark, limit sizes
This fixes a problem on CircleCI. Closes scipygh-22574 This also reduced the runtime of the `io_mm` benchmarks by 10x, it was super slow for no good reason because the benchmarks were run 3 times, 2x with fast-matrix-market and 1x with the old pure Python implementation. This looked like a left-over from the PR that switched to fast-matrix-market, demonstrating that `io.mmread` and `io.mmwrite` are the fast version and `io._mmio` is way slower. There is no need to keep running that. [skip actions] [skip cirrus]
1 parent b9b8b81 commit 09fb5ff

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

benchmarks/benchmarks/io_mm.py

+7-3
Original file line numberDiff line numberDiff line change
@@ -46,16 +46,20 @@ class MemUsage(Benchmark):
4646
def params(self):
4747
return [
4848
list(self._get_size().keys()),
49-
['scipy.io', 'scipy.io._mmio', 'scipy.io._fast_matrix_market'],
49+
['scipy.io'],
5050
['dense', 'coo'] # + ['csr']
5151
]
5252

5353
def _get_size(self):
5454
size = {
5555
'1M': int(1e6),
5656
'10M': int(10e6),
57-
'100M': int(100e6),
58-
'300M': int(300e6),
57+
'25M': int(10e6),
58+
# Note: the below sizes should work locally but cause issues on CircleCI
59+
# it fails to allocate memory even though there is easily enough
60+
# available (see gh-22574).
61+
#'100M': int(100e6),
62+
#'300M': int(300e6),
5963
# '500M': int(500e6),
6064
# '1000M': int(1000e6),
6165
}

0 commit comments

Comments
 (0)