Java source files with missing or non-standard copyright notices

[stephengold]

The authors of these classes need to be contacted so that we can make sure they've actually contributed them to the jMonkeyEngine project. Then the source files should be updated to the standard JME copyright notice.

checkers.quals.*
com.jme3.anim.AnimClip
com.jme3.anim.AnimComposer
com.jme3.anim.AnimTrack
com.jme3.anim.AnimationMask
com.jme3.anim.Armature
com.jme3.anim.ArmatureMask
com.jme3.anim.Joint
com.jme3.anim.MatrixJointModelTransform
com.jme3.anim.MorphControl
com.jme3.anim.SeparateJointModelTransform
com.jme3.anim.Weights
com.jme3.anim.interpolator.*
com.jme3.anim.tween.*
com.jme3.anim.tween.action.*
com.jme3.anim.util.*
com.jme3.app.DetailedProfiler
com.jme3.app.DetailedProfilerState
com.jme3.audio.AudioSource
com.jme3.audio.openal.AL

etcetera

[Ali-RS]

com.jme3.anim.AnimClip
com.jme3.anim.AnimComposer
com.jme3.anim.AnimTrack
com.jme3.anim.AnimationMask
com.jme3.anim.Armature
com.jme3.anim.ArmatureMask
com.jme3.anim.Joint
com.jme3.anim.MatrixJointModelTransform
com.jme3.anim.MorphControl
com.jme3.anim.SeparateJointModelTransform
com.jme3.anim.Weights
com.jme3.anim.interpolator.*
com.jme3.anim.tween.*
com.jme3.anim.tween.action.*
com.jme3.anim.util.*
com.jme3.app.DetailedProfiler
com.jme3.app.DetailedProfilerState

These are created by @Nehon so I believe we can update them to standard JME copyright.

[stephengold]

Many of them were created by @Nehon, but a few have SimSilica copyrights (meaning @pspeed42 created them.)

There are also files (not listed above) with other authorship. For example:
com.jme3.app.VRApplication

[Ali-RS]

@pspeed42 now that jme core utilise Tweens, do you think it would be good idea to deprecate them from Lemur and put them in jme core ?
Lemur already has dependency on jme core so this wont be an issue for Lemur.

[pspeed42]

I think they were changed after moving, weren't they?

[Ali-RS]

I think they were changed after moving, weren't they?

Yes, the following has changed:
A new interface added
https://github.com/jMonkeyEngine/jmonkeyengine/blob/master/jme3-core/src/main/java/com/jme3/anim/tween/ContainsTweens.java
and Parallel, Sequence, Stretch tweens implement it.
And AbstractTween now also implements JmeCloneable

https://github.com/jMonkeyEngine/jmonkeyengine/blob/13d00e0df3c10a40728834f36d40af04b8b00482/jme3-core/src/main/java/com/jme3/anim/tween/AbstractTween.java

@pspeed42 any issues with above changes ?

@pspeed42 , @stephengold if you feel this is out of scope of this issue, and it would be better to get asked in forum, please let me know.

[stephengold]

The discussion here seems appropriate to me.

[pspeed42]

I'm not ready to completely fold Lemur's version into JME yet. It's fine if JME takes them as a fork but I don't necessarily agree with how they were changed but neither do I want to make a hard decision about that right now. "ContainsTweens" is not a name I'd have ever picked... nor would I have returned the raw array. Not sure what it's used for, though.

[Ali-RS]

Ok, I see. Thanks.

"ContainsTweens" is not a name I'd have ever picked...

Yes, maybe "CompositeTween" or "BranchTween" would be a better name... anyway it's upto @Nehon I guess ;)

nor would I have returned the raw array. Not sure what it's used for, though.

This is only place I found it is used.

jmonkeyengine/jme3-core/src/main/java/com/jme3/anim/tween/action/BaseAction.java

Line 27 in d57c362

Tween[] tweens = ((ContainsTweens) tween).getTweens();

Many of them were created by @Nehon, but a few have SimSilica copyrights (meaning @pspeed42 created them.)

Should we keep SimSilica copyrights on those 3 classes (Tween.java, Tweens.java, AbstractTween.java) and use JME standard copyrights for the rest ?

[stephengold]

I just messaged @Nehon via a couple channels to clarify his intent.

[Whaleteeeth]

If the SimSilica copyright were used on those three specific classes and JME copyrights on others, does that resolve this issue? It seems like @pspeed42 has effectively given this permission to use the classes while maintaining their current copyrights. I think if the communication continued here, this issue could be resolved quite quickly, based on the interaction from these users above.

[pspeed42]

If it's an issue, you have my permission to re-license those files. Given that the licenses are otherwise compatible, I guess that is the smaller issue of this thread, though.

[stephengold]

PR #1274 addressed the special case of TextureGeneratorWood.java by deleting the file, since it had an incompatible license and we've lost touch with its author.

I'll go ahead and act on Paul's permission to re-license. However, that will leave a large number of files still to be dealt with.

[stephengold]

If someone claims authorship of a file and then commits it to our repository without a copyright notice, I think we can assume they intended to contribute it to out project. If we're no longer able to contact that person, perhaps we should assume the omission was an oversight. In that case, it seems appropriate to add an appropriate copyright notice and license.

I'll start making a list.