Merge pull request #21 from nulogy/support-rubocop-49

Support rubocop >= 0.49.0

Author: jakeonrails

.rubocop_schema.49.yml

@@ -0,0 +1,35 @@
+# Configuration for Rubocop >= 0.49.0
+
+Layout/AlignHash:
+  EnforcedColonStyle: 'key'
+  EnforcedHashRocketStyle: 'key'
+
+Layout/ExtraSpacing:
+  # When true, allows most uses of extra spacing if the intent is to align
+  # things with the previous or next line, not counting empty lines or comment
+  # lines.
+  AllowForAlignment: false
+
+Layout/SpaceBeforeFirstArg:
+  Enabled: true
+
+Style/NumericLiterals:
+  Enabled: false
+
+Metrics/BlockNesting:
+  Max: 2
+
+Style/WordArray:
+  Enabled: false
+
+Style/TrailingCommaInLiteral:
+  EnforcedStyleForMultiline: 'comma'
+
+Style/TrailingCommaInArguments:
+  EnforcedStyleForMultiline: 'comma'
+
+Style/HashSyntax:
+  EnforcedStyle: 'ruby19'
+
+Style/StringLiterals:
+  EnforcedStyle: double_quotes

.rubocop_schema.yml

@@ -1,3 +1,5 @@
+# Configuration for Rubocop >= 0.38.0, < 0.49.0
+
 Style/ExtraSpacing:
   # When true, allows most uses of extra spacing if the intent is to align
   # things with the previous or next line, not counting empty lines or comment

lib/fix_db_schema_conflicts/autocorrect_configuration.rb

@@ -0,0 +1,17 @@
+module FixDBSchemaConflicts
+  class AutocorrectConfiguration
+    def self.load
+      new.load
+    end
+
+    def load
+      at_least_rubocop_49? ? '.rubocop_schema.49.yml' : '.rubocop_schema.yml'
+    end
+
+    private
+
+    def at_least_rubocop_49?
+      Gem::Version.new('0.49.0') <= Gem.loaded_specs['rubocop'].version
+    end
+  end
+end

lib/fix_db_schema_conflicts/tasks/db.rake

@@ -1,15 +1,18 @@
 require 'shellwords'
+require_relative '../autocorrect_configuration'
 
 namespace :db do
   namespace :schema do
     task :dump do
       puts "Dumping database schema with fix-db-schema-conflicts gem"
+
       filename = ENV['SCHEMA'] || if defined? ActiveRecord::Tasks::DatabaseTasks
         File.join(ActiveRecord::Tasks::DatabaseTasks.db_dir, 'schema.rb')
       else
         "#{Rails.root}/db/schema.rb"
       end
-      rubocop_yml = File.expand_path('../../../../.rubocop_schema.yml', __FILE__)
+      autocorrect_config = FixDBSchemaConflicts::AutocorrectConfiguration.load
+      rubocop_yml = File.expand_path("../../../../#{autocorrect_config}", __FILE__)
       `bundle exec rubocop --auto-correct --config #{rubocop_yml} #{filename.shellescape}`
     end
   end

lib/fix_db_schema_conflicts/version.rb

@@ -1,3 +1,3 @@
 module FixDBSchemaConflicts
-  VERSION='3.0.1'
+  VERSION='3.0.2'
 end

spec/integration/integration_spec.rb

@@ -1,12 +1,12 @@
 require 'spec_helper'
 
-describe 'Fix DB Schema Conflicts' do
+RSpec.describe 'Fix DB Schema Conflicts' do
 
   let(:expected_lines) { reference_db_schema.lines }
 
   it 'generates a sorted schema with no extra spacing' do
 
-    `cd spec/test-app && rm db/schema.rb && rake db:migrate`
+    `cd spec/test-app && rm -f db/schema.rb && rake db:migrate`
 
     generated_lines = File.readlines('spec/test-app/db/schema.rb')
 

spec/spec_helper.rb

@@ -40,9 +40,9 @@
     mocks.verify_partial_doubles = true
   end
 
-# The settings below are suggested to provide a good initial experience
-# with RSpec, but feel free to customize to your heart's content.
-=begin
+  # The settings below are suggested to provide a good initial experience
+  # with RSpec, but feel free to customize to your heart's content.
+
   # These two settings work together to allow you to limit a spec run
   # to individual examples or groups you care about by tagging them with
   # `:focus` metadata. When nothing is tagged with `:focus`, all examples
@@ -53,7 +53,7 @@
   # Allows RSpec to persist some state between runs in order to support
   # the `--only-failures` and `--next-failure` CLI options. We recommend
   # you configure your source control system to ignore this file.
-  config.example_status_persistence_file_path = "spec/examples.txt"
+  # config.example_status_persistence_file_path = "spec/examples.txt"
 
   # Limits the available syntax to the non-monkey patched syntax that is
   # recommended. For more details, see:
@@ -79,7 +79,7 @@
   # Print the 10 slowest examples and example groups at the
   # end of the spec run, to help surface which specs are running
   # particularly slow.
-  config.profile_examples = 10
+  # config.profile_examples = 10
 
   # Run specs in random order to surface order dependencies. If you find an
   # order dependency and want to debug it, you can fix the order by providing
@@ -92,5 +92,4 @@
   # test failures related to randomization by passing the same `--seed` value
   # as the one that triggered the failure.
   Kernel.srand config.seed
-=end
 end

spec/unit/autocorrect_configuration_spec.rb

@@ -0,0 +1,23 @@
+require 'spec_helper'
+require 'fix_db_schema_conflicts/autocorrect_configuration'
+
+RSpec.describe FixDBSchemaConflicts::AutocorrectConfiguration do
+  subject(:autocorrect_config) { described_class }
+
+  it 'for versions up to 0.49.0' do
+    installed_rubocop(version: '0.39.0')
+
+    expect(autocorrect_config.load).to eq('.rubocop_schema.yml')
+  end
+
+  it 'for versions 0.49.0 and above' do
+    installed_rubocop(version: '0.49.0')
+
+    expect(autocorrect_config.load).to eq('.rubocop_schema.49.yml')
+  end
+
+  def installed_rubocop(version:)
+    allow(Gem).to receive_message_chain(:loaded_specs, :[], :version)
+      .and_return(Gem::Version.new(version))
+  end
+end