diff --git a/Directory.Build.props b/Directory.Build.props index e15aa73..c4efab6 100644 --- a/Directory.Build.props +++ b/Directory.Build.props @@ -4,8 +4,9 @@ preview.0 normal - henry-js - henry-js + true + jamesshenry + jamesshenry diff --git a/src/DotNetPathUtils.Tests/PathEnvironmentHelperTests.cs b/src/DotNetPathUtils.Tests/PathEnvironmentHelperTests.cs index e672cef..53b8b81 100644 --- a/src/DotNetPathUtils.Tests/PathEnvironmentHelperTests.cs +++ b/src/DotNetPathUtils.Tests/PathEnvironmentHelperTests.cs @@ -90,10 +90,7 @@ public async Task EnsureApplicationXdgConfigDirectoryIsInPath_Constructs_Correct _service.IsWindows().Returns(false); // Simulate running on Linux // Act - var result = _helper.EnsureApplicationXdgConfigDirectoryIsInPath( - null, - EnvironmentVariableTarget.User - ); + var result = _helper.EnsureApplicationXdgConfigDirectoryIsInPath(); // Assert await Assert.That(result.Status).IsEqualTo(PathUpdateStatus.PathAdded); @@ -274,9 +271,7 @@ public async Task RemoveApplicationXdgConfigDirectoryFromPath_When_Path_Exists_R .Returns(existingPath); // Act - var result = _helper.RemoveApplicationXdgConfigDirectoryFromPath( - EnvironmentVariableTarget.User - ); + var result = _helper.RemoveApplicationXdgConfigDirectoryFromPath(); // Assert await Assert.That(result.Status).IsEqualTo(PathRemoveStatus.PathRemoved); @@ -302,9 +297,7 @@ public async Task RemoveApplicationXdgConfigDirectoryFromPath_When_Path_Does_Not .Returns(existingPath); // Act - var result = _helper.RemoveApplicationXdgConfigDirectoryFromPath( - EnvironmentVariableTarget.User - ); + var result = _helper.RemoveApplicationXdgConfigDirectoryFromPath(); // Assert await Assert.That(result.Status).IsEqualTo(PathRemoveStatus.PathNotFound); diff --git a/src/DotNetPathUtils/PathEnvironmentHelper.cs b/src/DotNetPathUtils/PathEnvironmentHelper.cs index 32931a0..77a1a1b 100644 --- a/src/DotNetPathUtils/PathEnvironmentHelper.cs +++ b/src/DotNetPathUtils/PathEnvironmentHelper.cs @@ -11,8 +11,8 @@ public class PathEnvironmentHelper private readonly ILogger? _logger; public PathEnvironmentHelper( - ILogger? logger = null, - PathUtilsOptions? options = null + PathUtilsOptions? options = null, + ILogger? logger = null ) : this(new SystemEnvironmentService(), "PATH", options, logger) { } @@ -41,8 +41,8 @@ internal PathEnvironmentHelper( public PathModificationResult EnsureApplicationXdgConfigDirectoryIsInPath( string? appName = null, - EnvironmentVariableTarget target = EnvironmentVariableTarget.User, - PathUtilsOptions? methodOptions = null // Renamed for clarity + PathUtilsOptions? methodOptions = null, // Renamed for clarity + EnvironmentVariableTarget target = EnvironmentVariableTarget.User ) { var effectiveOptions = methodOptions ?? _options; @@ -157,9 +157,9 @@ .. currentPathVariable } public PathRemovalResult RemoveApplicationXdgConfigDirectoryFromPath( - EnvironmentVariableTarget target = EnvironmentVariableTarget.User, string? appName = null, - PathUtilsOptions? methodOptions = null + PathUtilsOptions? methodOptions = null, + EnvironmentVariableTarget target = EnvironmentVariableTarget.User ) { var effectiveOptions = methodOptions ?? _options;