Skip to content
This repository was archived by the owner on Feb 19, 2019. It is now read-only.

"join" plugin does not work. #10

Open
EugeneKay opened this issue Feb 3, 2014 · 6 comments
Open

"join" plugin does not work. #10

EugeneKay opened this issue Feb 3, 2014 · 6 comments
Labels
bug

Comments

@EugeneKay
Copy link
Contributor

The "join" plugin causes a crash when invoked as .join and/or generally does not work. Console log of crash:

$ ./gitinfo-irc.pl
[Mon Feb  3 19:00:58 2014] [INFO]    Control server started.
[Mon Feb  3 19:00:58 2014] [INFO]    Plugin 'join' loaded.
[Mon Feb  3 19:00:58 2014] [INFO]    Plugin 'text_trigger' loaded.
[Mon Feb  3 19:00:58 2014] [INFO]    IRC: connected to chat.freenode.net
Not an ARRAY reference at plugins/join.pm line 14.
$

Also mistakenly claims invalid channel name when invoked directly with .join #channel - suspect bad regex matching causing this one.

Running off the current HEAD + Pull Request #9 so this plugin will actually load.
jast added a commit that referenced this issue Feb 4, 2014
@jast
plugins/join: #10: fix command line parsing and interpretation of config
abf5205 
* Idiotically, Perl returns the size of the list if split() is used in scalar
  context. Make sure to use it in list context.
* Port the code that reads the list of channels from the config to the
  new(ish) scheme that uses a hashref instead of an arrayref.

Signed-off-by: Jan Krüger <[email protected]>
@jast
Copy link
Owner

jast commented Feb 4, 2014

Sorry, join is one of the plugins I haven't really used myself for some reason. Does the updated version work for you?

@EugeneKay
Copy link
Contributor Author

It does not complain as loudly, but the plugin does not work as intended. Interaction log follows:

<Eugene> .join
-CyanBot- Auto-joined configured channels: #cyanogenmod-dev, #cyanogenmod
<Eugene> .join #vlege
-CyanBot- You may not join me to channels that aren't configured. Sorry.

Channels list does include #vlege (bot was /kick'ed from it for test). But at least it doesn't crash anymore!

@jast
Copy link
Owner

jast commented Feb 8, 2014

No idea what's happening there. Once I get my computer moved to my new home (maybe next month?) I'll dig deeper...

@jast jast added the bug label Feb 14, 2014
@jast
Copy link
Owner

jast commented Feb 20, 2014

I just tested this in my production instance. WFM...

@jast
Copy link
Owner

jast commented Apr 30, 2014

Does this issue still exist for you? If so, please catch me on IRC some time so we can try and figure out what's going on.

@EugeneKay
Copy link
Contributor Author

It is still broken, yes. I am running off abf5205, but nothing since then touches this plugin. Catch me this weekend whenever is convenient for you.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jast @EugeneKay