update command validation error

Author: javaLux

src/cli.rs

@@ -106,9 +106,10 @@ pub struct LocalArgs {
 fn validate_output_target(target: &str) -> Result<PathBuf, String> {
     let path = PathBuf::from(target);
     if !path.is_dir() {
-        let cmd_err =
-            commands::CommandError::OutputTargetInvalid(utils::absolute_path_as_string(&path))
-                .to_string();
+        let cmd_err = commands::CommandValidationError::OutputTargetInvalid(
+            utils::absolute_path_as_string(&path),
+        )
+        .to_string();
         Err(cmd_err)
     } else {
         Ok(path)
@@ -123,7 +124,8 @@ fn check_file_name(filename: &str) -> Result<String, String> {
         Ok(_) => Ok(filename.to_string()),
         Err(validate_err) => {
             let cmd_err =
-                commands::CommandError::InvalidFilename(validate_err.to_string()).to_string();
+                commands::CommandValidationError::InvalidFilename(validate_err.to_string())
+                    .to_string();
             Err(cmd_err)
         }
     }
@@ -134,7 +136,8 @@ fn validate_hash_target(target: &str) -> Result<PathBuf, String> {
     let path = PathBuf::from(target);
     if !path.exists() {
         let cmd_err =
-            commands::CommandError::PathNotExist(utils::absolute_path_as_string(&path)).to_string();
+            commands::CommandValidationError::PathNotExist(utils::absolute_path_as_string(&path))
+                .to_string();
         Err(cmd_err)
     } else {
         Ok(path)

src/commands.rs

@@ -27,40 +27,41 @@ pub struct HashCompareResult {
 
 // Represents possible cli command errors
 #[derive(Debug, PartialEq, PartialOrd)]
-pub enum CommandError {
+pub enum CommandValidationError {
     PathNotExist(String),
     InvalidUrl,
     InvalidHashSum,
     OutputTargetInvalid(String),
     InvalidFilename(String),
 }
 
-impl Error for CommandError {}
+impl Error for CommandValidationError {}
 
-impl fmt::Display for CommandError {
+impl fmt::Display for CommandValidationError {
     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
+        let prefix = "Validation failed →";
         match self {
-            CommandError::PathNotExist(path) => {
+            CommandValidationError::PathNotExist(path) => {
                 let msg = format!("The specified path '{}' does not exist", path);
                 write!(f, "{}", msg)
             }
-            CommandError::InvalidUrl => {
-                write!(f, "Command error => The specified URL is invalid. Please ensure the URL is correctly formatted, including the scheme (e.g. 'http://', 'https://'). For example: https://example.com")
+            CommandValidationError::InvalidUrl => {
+                write!(f, "{prefix} The specified URL is invalid. Please ensure the URL is correctly formatted, including the scheme (e.g. 'http://', 'https://'). For example: https://example.com")
             }
-            CommandError::InvalidHashSum => {
+            CommandValidationError::InvalidHashSum => {
                 write!(
                     f,
-                    "Command error => The specified hash sum is not a valid hexadecimal digit"
+                    "{prefix} The specified hash sum is not a valid hexadecimal digit"
                 )
             }
-            CommandError::OutputTargetInvalid(target) => {
+            CommandValidationError::OutputTargetInvalid(target) => {
                 let msg = format!(
-                    "Invalid target - '{}' does not exist or is not a directory",
+                    "Invalid output target - '{}' does not exist or is not a directory",
                     target
                 );
                 write!(f, "{}", msg)
             }
-            CommandError::InvalidFilename(filename_err) => {
+            CommandValidationError::InvalidFilename(filename_err) => {
                 let msg = format!("Invalid filename - {}", filename_err);
                 write!(f, "{}", msg)
             }
@@ -86,14 +87,14 @@ pub fn handle_download_cmd(args: DownloadArgs, os_type: os_specifics::OS) -> Res
     let download_url = &args.url;
 
     if !utils::is_valid_url(download_url) {
-        let command_err = CommandError::InvalidUrl;
+        let command_err = CommandValidationError::InvalidUrl;
         return Err(command_err.into());
     }
 
     // Check if the provided hash is a valid hex digit
     if let Some(origin_hash_sum) = args.hash_sum.as_ref() {
         if !verify::is_hash_valid(origin_hash_sum) {
-            return Err(CommandError::InvalidHashSum.into());
+            return Err(CommandValidationError::InvalidHashSum.into());
         }
     }
 
@@ -136,7 +137,7 @@ pub fn handle_local_cmd(args: LocalArgs) -> Result<()> {
     let cmd_result = if let Some(origin_hash_sum) = args.hash_sum {
         // Check if the provided hash is a valid hex digit
         if !verify::is_hash_valid(&origin_hash_sum) {
-            return Err(CommandError::InvalidHashSum.into());
+            return Err(CommandValidationError::InvalidHashSum.into());
         }
 
         let is_hash_equal = verify::is_hash_equal(&origin_hash_sum, &calculated_hash_sum);