Fix explicit casts #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kim-anchorzero
requested review from
dmitri-anchorzero and
jcoveney-anchorzero
dmitri-anchorzero
approved these changes
Sep 17, 2024
| @@ -347,7 +347,7 @@ export class SQLFragment<RunResult = pg.QueryResult['rows'], Constraint = never> | |||
|
|
|||
| } else if (typeof expression.cast === 'string') { | |||
| result.values.push(expression.value); | |||
| result.text += `CAST(${placeholder} AS "${expression.cast}")`; | |||
| result.text += `CAST(${placeholder} AS ${expression.cast})`; | |||
There was a problem hiding this comment.
Not sure I follow what removing the quotes fixes. Can you elucidate? Quickly checking in pgAdmin query tool seems like the quotes are indeed not needed, but also not harmful there.
There was a problem hiding this comment.
With the quotes I was getting errors.. except when the value was "json." All other quoted type strings would fail.
There was a problem hiding this comment.
Can't argue with empiricism!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes jawj#180. @dmitri-anchorzero this could be of use in the new json subquery stuff when using zapatos.param()