Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot compile with exceptions disabled #1147

Open
fansehep opened this issue Oct 28, 2022 · 1 comment
Open

Cannot compile with exceptions disabled #1147

fansehep opened this issue Oct 28, 2022 · 1 comment

Comments

@fansehep
Copy link

Hi guys.
I can not compile the latest version of yaml-cpp with -fno-exception in latest gcc and clang.
Should fix it?
2022-10-28_13-10-1666936765

@OndrejPopp
Copy link

OndrejPopp commented May 11, 2023

Me neither.

The question is whether enabling exceptions just for this library gives a performance penalty...
I had a look at the code, and there are just a few instances where exceptions are being thown, and only to signal that a node is not valid. So that could be disabled and then this library will compile just fine with exceptions disabled.

Ok, found it,
This has already been taken care of in the following unmerged pull request,
#1146

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants