pull-review influenced fixes

Author: jbruggem

lib/papers.functions.js

@@ -1,15 +1,15 @@
 
 // if we are in a node env
-if(typeof(exports) == 'object'){
+if(typeof(exports) === 'object'){
   publicObject = exports;
 
 // if we are in the browser
 }else{
   publicObject = {};
-  papersLib = publicObject;
+  var papersLib = publicObject;
 }
 
-if( 'undefined' != typeof($)) publicObject.$ = $;
+if( 'undefined' !== typeof($)) publicObject.$ = $;
 
 
 /**

lib/papers.js

@@ -1,6 +1,6 @@
 
 // if we are in a node env
-if(typeof(exports) == 'object'){
+if(typeof(exports) === 'object'){
   var papersLib = require('./papers.functions.js');
   publicObject = exports;
 
@@ -10,7 +10,7 @@ if(typeof(exports) == 'object'){
   papers = publicObject;
 }
 
-if( 'undefined' != typeof($)) publicObject.$ = $;
+if( 'undefined' !== typeof($)) publicObject.$ = $;
 
 publicObject.debug = false;
 
@@ -51,23 +51,23 @@ publicObject.formatters = {
 
   // private functions with no side-effects are loaded seperately
   // this is done so that these can be unit tested
-  var appendElem = papersLib.appendElem 
+  var appendElem = papersLib.appendElem;
 
   public.addDataToDocument = function(list,sourceElement,targetElement,formatter){
 
     if(public.debug)
       console.log(list,sourceElement,targetElement,formatter);
 
-    if(0 == publicObject.$(sourceElement).length)
+    if(0 === publicObject.$(sourceElement).length)
       throw new Error("sourceElement is empty.");
 
-    if(0 == publicObject.$(targetElement).length)
+    if(0 === publicObject.$(targetElement).length)
       throw new Error("targetElement is empty.");
 
     publicObject.$(list).each(function(index,item){
       appendElem(item,sourceElement,targetElement,formatter);
     });
-  }
+  };
 
   public.helpers = {};
 
@@ -86,7 +86,7 @@ publicObject.formatters = {
       );
 
     return list;
-  }
+  };
 
   /**
    * Duplicate each element of a list to make it longer
@@ -103,9 +103,9 @@ publicObject.formatters = {
         newList.push(list[i]);
 
     return newList;
-  }
+  };
 
-})(publicObject)
+})(publicObject);
 
 
 

test/test.papers.js

@@ -19,13 +19,13 @@ describe('papers', function() {
   var $ = zeptoEnv;
 
   var dataList = function(){ return [
-    {'tit': "a", 'img': "src/img/a", 'txt': "test a text" },
-    {'tit': "b", 'img': "src/img/b", 'txt': "test b text" },
-    {'tit': "c", 'img': "src/img/c", 'txt': "test c text" },
-  ]; 
-  }
+      {'tit': "a", 'img': "src/img/a", 'txt': "test a text" },
+      {'tit': "b", 'img': "src/img/b", 'txt': "test b text" },
+      {'tit': "c", 'img': "src/img/c", 'txt': "test c text" },
+    ]; 
+  };
 
-  var srcElem = function(){ return "<section><h3></h3><img/><p></p></section>"; }
+  var srcElem = function(){ return "<section><h3></h3><img/><p></p></section>"; };
 
   describe('paper object' , function() {