An improper locking bug(e.g., deadlock) on the lock h->cache_mutex

[ycaibb]

Hi, developers, thank you for your checking. It seems the lock h->cache_mutex is not released correctly when newBlocks == NULL in the function chm_set_param?

CHMLib/src/chm_lib.c

Lines 1026 to 1035 in 2bef8d0

	CHM_ACQUIRE_LOCK(h->cache_mutex);
	if (paramVal != h->cache_num_blocks)
	{
	UChar **newBlocks;
	UInt64 *newIndices;
	int i;
	/* allocate new cached blocks */
	newBlocks = (UChar **)malloc(paramVal * sizeof (UChar *));
	if (newBlocks == NULL) return;

[ycaibb]

Hi, developers @jedwing

Any comments would be highly appreciated. Thank you.

Best Regards,

[jedwing]

I haven't touched this code in many years, but I think you are right - that does look like a bug.

…

On Thu, Sep 9, 2021 at 4:43 AM ycaibb ***@***.***> wrote: Hi, developers @jedwing <https://github.com/jedwing> Any comments would be highly appreciated. Thank you. Best Regards, — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#14 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAVOHVCOSWRVZWHWEAJGCDUBCMUJANCNFSM5DPZRTHA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

-- - jed