[Feature]: Include non-printable control characters such as \x01 in the console "Expected:" and "Received:" outputs.

[fixparser]

🚀 Feature Proposal

Include all control characters in the console, properly escaped so the <SOH> character is printed as \x01. It's currently stripped from the printed string.

Motivation

A lot of our tests uses these special characters and it creates extra work/steps due to the removal of these characters.

Example

This:

Expected: "8=FIXT.1.19=6835=A34=149=ISLD52=00000000-00:00:00.00056=TW98=0108=301137=910=0"
Received: "8=FIXT.1.135=A34=149=ISLD52=<TIME>56=TW141=N98=0108=30"

Should print as this:

Expected: "8=FIXT.1.1\x019=68\x0135=A\x0134=1\x0149=ISLD\x0152=00000000-00:00:00.000\x0156=TW\x0198=0\x01108=30\x011137=9\x0110=0\x01"
Received: "8=FIXT.1.1\x0135=A\x0134=1\x0149=ISLD\x0152=<TIME>\x0156=TW\x01141=N\x0198=0\x01108=30"

Pitch

Hopefully a simple change to include these characters, would be super helpful for our use case. Cheers

[github-actions]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 30 days.

[icholy]

This looks more like a bug than a feature request.

[github-actions]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 30 days.

[yagni]

Got bit by this one today

[fixparser]

@SimenB or @mrazauskas any thoughts?

[mrazauskas]

Do you have in mind snapshots or something else? If snapshots is the problem, might be worth trying jest-serializer-ansi-escapes. It can be you are looking for something else. Not sure I fully understand the problem, sorry.

[yagni]

Hopefully the below image can help. The two strings look identical, but one of them has the following string between the ! and the Ø: \u001b-A\u0083 (the other string does not have anything between the ! and the Ø). For some reason those 4 characters completely get stripped out from the display.

This problem happens on a standard string compare expect: expect(allLoggedText).toEqual(expectedLog);

jest correctly detects that there's a diff (seems to be the case for @fixparser as well). It's almost as though the problem is purely that the 4 characters aren't displayed in the output.

[github-actions]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 30 days.