Skip to content

[Bug]: Incorrect comparison with calledWith(objectContaining) and multiple calls (reopening) #15501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ecraig12345 opened this issue Feb 11, 2025 · 6 comments · May be fixed by #15508
Open

[Bug]: Incorrect comparison with calledWith(objectContaining) and multiple calls (reopening) #15501

ecraig12345 opened this issue Feb 11, 2025 · 6 comments · May be fixed by #15508
Labels
Bug Report Needs Triage

Comments

@ecraig12345
Copy link

ecraig12345 commented Feb 11, 2025 •
edited
Loading

This was originally opened by @glenjamin in #15342, but it was closed due to inactivity.

Version

30.0.0-alpha.7

Steps to reproduce

describe('something', () => {
  it('should work', () => {
    const f = jest.fn();
    f({ a: 1, b: 2 });
    f({ a: 3, b: 7 });

    expect(f).toHaveBeenCalledWith(expect.objectContaining({ b: 7 }));
  });
});

Expected behavior

Test passes

Actual behavior

 FAIL  ./demo.test.js
  something
    ✕ should work (38 ms)

  ● something › should work

    expect(jest.fn()).toHaveBeenCalledWith(...expected)

    Expected: ObjectContaining {"a": 1, "b": 7}
    Received
           1: {"a": 1, "b": 2}
           2: {"a": 3, "b": 7}

    Number of calls: 2

       5 |     f({ a: 3, b: 7 });
       6 |
    >  7 |     expect(f).toHaveBeenCalledWith(expect.objectContaining({ b: 7 }));
         |               ^
       8 |   });
       9 | });
      10 |

      at Object.toHaveBeenCalledWith (demo.test.js:7:15)

Additional context

@glenjamin's comment on the original issue #15342:

I've traced this back to 169ba83#diff-f8846ea7aae48b4baadb9c50ba129cdadc6783e6051e605b5e2827153fc04479R253

The assumption that this.sample is safe to modify is incorrect.

I expect that this will fail in any scenario where objectContaining is compared against multiple values

cc @colinacassidy who supplied the previous fix

Environment

System:
    OS: macOS 15.2
    CPU: (10) arm64 Apple M1 Max
  Binaries:
    Node: 18.20.1
    Yarn: 4.4.0
    npm: 9.9.3
    pnpm: 9.1.0
  npmPackages:
    jest: ^30.0.0-alpha.5 => 30.0.0-alpha.7
@ecraig12345 ecraig12345 linked a pull request Feb 15, 2025 that will close this issue
Open
@github-actions GitHub Actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the Stale label Mar 13, 2025
@ecraig12345
Copy link
Author

Still a problem, with a PR submitted for a fix...

@github-actions github-actions bot removed the Stale label Mar 14, 2025
@github-actions GitHub Actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the Stale label Apr 13, 2025
@ecraig12345
Copy link
Author

Still an issue...

@github-actions github-actions bot removed the Stale label Apr 14, 2025
@github-actions GitHub Actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the Stale label May 14, 2025
@ecraig12345
Copy link
Author

Still waiting for review of the PR...

@github-actions github-actions bot removed the Stale label May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Report Needs Triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix calledWith(objectContaining) when there are multiple calls ecraig12345/jest
1 participant
@ecraig12345