Skip to content

Commit 33626bc

Browse files
gaearonjetoneza
authored andcommitted
Fix Suspense fixture (facebook#13932)
1 parent d8696fa commit 33626bc

File tree

4 files changed

+6
-15
lines changed

4 files changed

+6
-15
lines changed

fixtures/unstable-async/suspense/src/cache.js

Lines changed: 0 additions & 7 deletions
This file was deleted.

fixtures/unstable-async/suspense/src/components/ContributorListPage.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import React, {Fragment} from 'react';
22
import {unstable_createResource} from 'react-cache';
3-
import {cache} from '../cache';
43
import Spinner from './Spinner';
54
import {fetchCoreContributorListJSON} from '../api';
65

@@ -19,7 +18,7 @@ const ContributorListPage = ({loadingId, onUserClick}) => (
1918
padding: 0,
2019
margin: 0,
2120
}}>
22-
{ContributorListResource.read(cache).map(user => (
21+
{ContributorListResource.read().map(user => (
2322
<ContributorListItem
2423
key={user.id}
2524
onClick={() => onUserClick(user.id)}

fixtures/unstable-async/suspense/src/components/UserPage.js

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import React, {Suspense} from 'react';
22
import {unstable_createResource} from 'react-cache';
33
import Spinner from './Spinner';
4-
import {cache} from '../cache';
54
import {fetchUserProfileJSON, fetchUserRepositoriesListJSON} from '../api';
65

76
export default function UserPage({id}) {
@@ -24,7 +23,7 @@ export default function UserPage({id}) {
2423
const UserDetailsResource = unstable_createResource(fetchUserProfileJSON);
2524

2625
function UserDetails({id}) {
27-
const user = UserDetailsResource.read(cache, id);
26+
const user = UserDetailsResource.read(id);
2827
return (
2928
<div
3029
style={{
@@ -113,7 +112,7 @@ const ImageResource = unstable_createResource(
113112
);
114113

115114
function Img({src, alt, ...rest}) {
116-
return <img src={ImageResource.read(cache, src)} alt={alt} {...rest} />;
115+
return <img src={ImageResource.read(src)} alt={alt} {...rest} />;
117116
}
118117

119118
function UserPicture({source}) {
@@ -137,7 +136,7 @@ const UserRepositoriesResource = unstable_createResource(
137136
);
138137

139138
function Repositories({id}) {
140-
const repos = UserRepositoriesResource.read(cache, id);
139+
const repos = UserRepositoriesResource.read(id);
141140
return (
142141
<ul
143142
style={{

fixtures/unstable-async/suspense/src/index.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import React, {Fragment, PureComponent} from 'react';
22
import {unstable_createRoot, render} from 'react-dom';
33
import {unstable_trace as trace} from 'scheduler/tracing';
4-
import {cache} from './cache';
54
import {
65
setFakeRequestTime,
76
setPaused,
@@ -66,7 +65,8 @@ class Debugger extends PureComponent {
6665

6766
handleReset = () => {
6867
trace('Clear cache', performance.now(), () => {
69-
cache.invalidate();
68+
// TODO: this is not implemented.
69+
// cache.invalidate();
7070
this.setState(state => ({
7171
requests: {},
7272
}));

0 commit comments

Comments
 (0)