@wendigo definitely a good to have.

@wendigo this might be trickier than expected.

The default max size for BufferingResponseListener is 2 MiB.

The default max capacity for ArrayByteBufferPool is 64 KiB.

If the response content is within 64 KiB, then the ByteBuffer is pooled, otherwise the pool will just allocate it on-the-fly like BufferingResponseListener is doing right now.

So yes, there is a benefit for small content, but for larger content you need to size the ArrayByteBufferPool max capacity accordingly.

@sbordet that's why in the PR i've posted I've used NonPooled one to make it compatible with the current implementation. For the pooled usage, the consumer should be responsible for providing a pool that actually pools

@wendigo do you need this in 12.0.x?

I ask because there is a better way to manage the buffers without the ByteBufferPool just by retaining the content chunks, accumulating them, and converting them to a byte[] only once at the end.
Since there is no copy, there are no buffers involved, and hence no need of ByteBufferPool.

However, the behavior of BufferingResponseListener would be slightly changed, and it would be best for this behavior change to be in 12.1.x.

WDYT?

12.1 works for me