Once a tool is verified in a pipeline run, all subsequent stages in the same run + * skip the version check entirely — avoiding repeated HTTP HEAD requests to Artifactory. + * A new pipeline run produces a different run ID, so it gets its own verification. + * The agent OS is included in the key to distinguish same-path installations on + * agents with different architectures (e.g., linux-amd64 vs linux-arm64).
+ */ + private static final int MAX_CACHE_SIZE = 1000; + private static final Map+ * In Pipeline builds, the TaskListener wraps a FileLogStorage whose log file path + * contains the job name and build number (e.g., "jobs/my-job/builds/42/log"). + * This path is guaranteed unique per pipeline run. + *
+ * Falls back to null for non-Pipeline builds (Freestyle, etc.) where the listener + * structure is different — the caller treats null as "don't cache". + *
+ * Fragile: This relies on internal field names in workflow-api and workflow-support.
+ * Tested with Jenkins {@literal >=} 2.462.3 and workflow-cps. If a future Jenkins update
+ * renames these fields, the catch block returns null and caching degrades gracefully
+ * (repeated version checks, no failure). Re-verify after major Jenkins core upgrades.
+ */
+ private static String getCurrentRunId(TaskListener log) {
+ try {
+ // Reflection chain (workflow-api / workflow-support internals):
+ // CloseableTaskListener → mainDelegate (BufferedBuildListener) → out (IndexOutputStream) → this$0 (FileLogStorage) → log (File)
+ java.lang.reflect.Field mainField = log.getClass().getDeclaredField("mainDelegate");
+ mainField.setAccessible(true);
+ Object buildListener = mainField.get(log);
+
+ java.lang.reflect.Field outField = buildListener.getClass().getDeclaredField("out");
+ outField.setAccessible(true);
+ Object indexOut = outField.get(buildListener);
+
+ java.lang.reflect.Field storageField = indexOut.getClass().getDeclaredField("this$0");
+ storageField.setAccessible(true);
+ Object fileLogStorage = storageField.get(indexOut);
+
+ java.lang.reflect.Field logField = fileLogStorage.getClass().getDeclaredField("log");
+ logField.setAccessible(true);
+ File logFile = (File) logField.get(fileLogStorage);
+
+ return logFile.getPath();
+ } catch (Exception e) {
+ // Non-Pipeline build or different Jenkins version — fall back gracefully
+ LOGGER.fine("Could not determine pipeline run ID: " + e.getMessage());
+ return null;
+ }
+ }
+
+ private static void markVerified(String cacheKey, String currentRunId) {
+ if (currentRunId == null) {
+ return;
+ }
+ VERIFIED_IN_RUN.put(cacheKey, currentRunId);
+ }
+
/**
* Creates a unique lock key for the installation location.
* Version is excluded so all operations targeting the same binary path are serialized.
- *
- * @param toolLocation Installation directory
- * @param binaryName Binary file name
- * @return Unique lock key string
*/
private static String createLockKey(FilePath toolLocation, String binaryName) {
try {
@@ -267,17 +387,14 @@ public long[] invoke(File file, VirtualChannel channel) {
* @param log Task listener for logging
* @return true if CLI is the correct version, false otherwise
*/
- private static boolean isCorrectVersion(FilePath toolLocation, JFrogPlatformInstance instance,
- String repository, String version, String binaryName, TaskListener log) {
+ private static boolean isCorrectVersion(FilePath toolLocation, JFrogPlatformInstance instance,
+ String repository, String version, String binaryName,
+ String agentOsDetails, TaskListener log) {
try {
- // Use the same logic as shouldDownloadTool() from JFrogCliDownloader
- // but do it here to avoid unnecessary JFrogCliDownloader.invoke() calls
-
JenkinsProxyConfiguration proxyConfiguration = new JenkinsProxyConfiguration();
- // Use binaryName to construct the correct URL suffix (handles Windows jf.exe vs Unix jf)
- String cliUrlSuffix = String.format("/%s/v2-jf/%s/jfrog-cli-%s/%s", repository,
- StringUtils.defaultIfBlank(version, "[RELEASE]"),
- OsUtils.getOsDetails(), binaryName);
+ String cliUrlSuffix = String.format("/%s/v2-jf/%s/jfrog-cli-%s/%s", repository,
+ StringUtils.defaultIfBlank(version, "[RELEASE]"),
+ agentOsDetails, binaryName);
JenkinsBuildInfoLog buildInfoLog = new JenkinsBuildInfoLog(log);
String artifactoryUrl = instance.inferArtifactoryUrl();
@@ -295,6 +412,8 @@ private static boolean isCorrectVersion(FilePath toolLocation, JFrogPlatformInst
String expectedSha256 = getArtifactSha256(manager, cliUrlSuffix);
if (expectedSha256.isEmpty()) {
log.getLogger().println("[BinaryInstaller] WARNING: No SHA256 available from server — cannot verify version, assuming up-to-date (upgrade may be delayed)");
+ // Clean up stale 0-byte sha256 file left by older plugin versions
+ cleanupStaleSha256File(toolLocation, log);
return true;
}
@@ -319,6 +438,31 @@ public Boolean invoke(File f, VirtualChannel channel) throws IOException, Interr
}
}
+ /**
+ * Removes a stale 0-byte sha256 file left behind by older plugin versions.
+ * The file has no effect on current behaviour but can confuse operators inspecting
+ * the tool directory.
+ */
+ private static void cleanupStaleSha256File(FilePath toolLocation, TaskListener log) {
+ try {
+ toolLocation.act(new MasterToSlaveFileCallable