Further v2 changes in Lexer, Parser?

[rob-ross]

I just got the unit tests from the RFC project to all pass in my Java version of this project. Of course, that's a limited subset of the full feature set. You made quite a few changes recently on the v2 branch. How stable is this now that you have merged to main? I'm playing catch up with the refactoring and renaming of things. Luckily I've only been working on core RFC features so some of the extensions that have changed haven't affected me. If they're generally stable now (at least the class names and APIs) then I won't be trying to integrate a moving target. :)

[jg-rp]

I don't plan on making any more API or internal class changes before release of version 2 (or for a long time after that), so you can can consider it stable.

Hopefully the new names will make more sense than the old ones, especially if you're referring to the spec regularly. And, if you haven't already built the updated docs locally, the updated syntax guide should help when it comes to implementing any of the non-standard JSONPath syntax.

A note on the "high-level API" names

This project uses findall, finditer, "match", etc. to resemble Python's re module (Neither findall or finditer follow Python function naming conversions. They are like that for historical reasons).

python-jsonpath-rfc9535 uses find, finditer and "node".

ruby-json-p3 uses find, find_enum and "node".

My recommendation is to choose names that make the most sense for the language you're writing in, but favour "node" and "node list" over "match" and "matches" to better match the spec.

[rob-ross]

I was also referring to class names like JSONPathQuery vs JSONPath. Although that just might be different between the two projects.

[jg-rp]

I intend to leave the high-level API as is. For ease of upgrade for anyone moving from 1.x to 2, even though it differs from python-jsonpath-rfc9535 and the spec.

With hindsight maybe just Query or JSONPathExpression or CompiledJSONPathExpression would be better. 🤷‍♂️

[rob-ross]

I called mine WellFormedValidQuery in my Python project. But this was never going to be the public API name, just the internal name. Had I continued development I would have exposed it via a facade named JSONPathQuery, which is exactly what you are using. I like precise naming. :)