From 065cc8458b5ec6c93f22381355444f912950d6e5 Mon Sep 17 00:00:00 2001 From: jhj0517 <97279763+jhj0517@users.noreply.github.com> Date: Wed, 22 Jan 2025 20:30:12 +0900 Subject: [PATCH 1/3] Remove error raising when audio is silent --- modules/whisper/base_transcription_pipeline.py | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/modules/whisper/base_transcription_pipeline.py b/modules/whisper/base_transcription_pipeline.py index 8172a25b..9c66566b 100644 --- a/modules/whisper/base_transcription_pipeline.py +++ b/modules/whisper/base_transcription_pipeline.py @@ -15,6 +15,7 @@ from modules.utils.paths import (WHISPER_MODELS_DIR, DIARIZATION_MODELS_DIR, OUTPUT_DIR, DEFAULT_PARAMETERS_CONFIG_PATH, UVR_MODELS_DIR) from modules.utils.constants import * +from modules.utils.logger import get_gradio_logger from modules.utils.subtitle_manager import * from modules.utils.youtube_manager import get_ytdata, get_ytaudio from modules.utils.files_manager import get_media_files, format_gradio_files, load_yaml, save_yaml, read_file @@ -23,6 +24,9 @@ from modules.vad.silero_vad import SileroVAD +logger = get_gradio_logger() + + class BaseTranscriptionPipeline(ABC): def __init__(self, model_dir: str = WHISPER_MODELS_DIR, @@ -158,12 +162,14 @@ def run(self, ) if vad_params.vad_filter: - result = self.vad.restore_speech_timestamps( + restored_result = self.vad.restore_speech_timestamps( segments=result, speech_chunks=speech_chunks, ) - if not result: - raise ValueError("VAD detected no speech segments in the audio.") + if restored_result: + result = restored_result + else: + logger.info("VAD detected no speech segments in the audio.") if diarization_params.is_diarize: result, elapsed_time_diarization = self.diarizer.run( From b854ee92977c827b840360b8efa73a2f305a8e83 Mon Sep 17 00:00:00 2001 From: jhj0517 <97279763+jhj0517@users.noreply.github.com> Date: Wed, 22 Jan 2025 20:31:59 +0900 Subject: [PATCH 2/3] Remove deprecated loggers --- modules/utils/logger.py | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/modules/utils/logger.py b/modules/utils/logger.py index 4f71bd38..314d65a5 100644 --- a/modules/utils/logger.py +++ b/modules/utils/logger.py @@ -1,15 +1,10 @@ import logging +from typing import Optional -def get_gradio_logger(): - return get_logger("Whisper-WebUI") - - -def get_backend_logger(): - return get_logger("Whisper-WebUI-Backend") - - -def get_logger(name: str): +def get_logger(name: Optional[str] = None): + if name is None: + name = "Whisper-WebUI" logger = logging.getLogger(name) if not logger.handlers: From 34c730f98a93d41e7a578cff0bc20cbc1dc52dff Mon Sep 17 00:00:00 2001 From: jhj0517 <97279763+jhj0517@users.noreply.github.com> Date: Wed, 22 Jan 2025 20:32:14 +0900 Subject: [PATCH 3/3] Use `get_logger` --- modules/whisper/base_transcription_pipeline.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/whisper/base_transcription_pipeline.py b/modules/whisper/base_transcription_pipeline.py index 9c66566b..17ac796a 100644 --- a/modules/whisper/base_transcription_pipeline.py +++ b/modules/whisper/base_transcription_pipeline.py @@ -15,7 +15,7 @@ from modules.utils.paths import (WHISPER_MODELS_DIR, DIARIZATION_MODELS_DIR, OUTPUT_DIR, DEFAULT_PARAMETERS_CONFIG_PATH, UVR_MODELS_DIR) from modules.utils.constants import * -from modules.utils.logger import get_gradio_logger +from modules.utils.logger import get_logger from modules.utils.subtitle_manager import * from modules.utils.youtube_manager import get_ytdata, get_ytaudio from modules.utils.files_manager import get_media_files, format_gradio_files, load_yaml, save_yaml, read_file @@ -24,7 +24,7 @@ from modules.vad.silero_vad import SileroVAD -logger = get_gradio_logger() +logger = get_logger() class BaseTranscriptionPipeline(ABC):