From 796e82cc63c3931f4335d6c1fe2802e2e66145d0 Mon Sep 17 00:00:00 2001
From: tsteven4 <13596209+tsteven4@users.noreply.github.com>
Date: Sat, 29 Jan 2022 12:51:59 -0700
Subject: [PATCH] allow ignore list and skip list to be const. (#845)

---
 xmlgeneric.cc | 22 +++++++++++-----------
 xmlgeneric.h  |  8 ++++----
 2 files changed, 15 insertions(+), 15 deletions(-)

diff --git a/xmlgeneric.cc b/xmlgeneric.cc
index 540b1f474..96bcf0d5a 100644
--- a/xmlgeneric.cc
+++ b/xmlgeneric.cc
@@ -67,7 +67,7 @@ static QTextCodec* codec = utf8_codec;  // Qt has no vanilla ASCII encoding =(
  * xml strains and insulates us from a lot of the grubbiness of expat.
  */
 
-XgCallbackBase*
+static XgCallbackBase*
 xml_tbl_lookup(const QString& tag, xg_cb_type cb_type)
 {
   const QByteArray key = tag.toUtf8();
@@ -80,9 +80,9 @@ xml_tbl_lookup(const QString& tag, xg_cb_type cb_type)
   return nullptr;
 }
 
-void
+static void
 xml_common_init(const QString& fname, const char* encoding,
-         const char** ignorelist, const char** skiplist)
+                const char* const* ignorelist, const char* const* skiplist)
 {
   rd_fname = fname;
 
@@ -109,7 +109,7 @@ xml_common_init(const QString& fname, const char* encoding,
 
 void
 xml_init(const QString& fname, QList<xg_tag_map_entry>* tbl, const char* encoding,
-         const char** ignorelist, const char** skiplist, bool dynamic_tbl)
+         const char* const* ignorelist, const char* const* skiplist, bool dynamic_tbl)
 {
   xg_tag_tbl = tbl;
   dynamic_tag_tbl = dynamic_tbl;
@@ -119,12 +119,12 @@ xml_init(const QString& fname, QList<xg_tag_map_entry>* tbl, const char* encodin
 
 void
 xml_init(const QString& fname, xg_tag_mapping* tbl, const char* encoding,
-         const char** ignorelist, const char** skiplist)
+         const char* const* ignorelist, const char* const* skiplist)
 {
   xg_tag_tbl = new QList<xg_tag_map_entry>;
   dynamic_tag_tbl = true;
   for (xg_tag_mapping* tm = tbl; tm->tag_cb != nullptr; ++tm) {
-  auto* cb = new XgFunctionPtrCallback(tm->tag_cb);
+    auto* cb = new XgFunctionPtrCallback(tm->tag_cb);
     xg_tag_tbl->append({cb, tm->cb_type, tm->tag_name});
   }
 
@@ -155,10 +155,10 @@ xml_deinit()
 static xg_shortcut
 xml_shortcut(QStringView name)
 {
-   QString key = name.toString();
-   if (xg_shortcut_taglist->contains(key)) {
-     return xg_shortcut_taglist->value(key);
-   }
+  QString key = name.toString();
+  if (xg_shortcut_taglist->contains(key)) {
+    return xg_shortcut_taglist->value(key);
+  }
   return xg_shortcut_none;
 }
 
@@ -191,7 +191,7 @@ xml_run_parser(QXmlStreamReader& reader)
         goto readnext;
       default:
         break;
-     }
+      }
 
       current_tag.append(QLatin1Char('/'));
       current_tag.append(reader.qualifiedName());
diff --git a/xmlgeneric.h b/xmlgeneric.h
index 18580108e..5c7189fb5 100644
--- a/xmlgeneric.h
+++ b/xmlgeneric.h
@@ -149,11 +149,11 @@ QList<xg_tag_map_entry>* build_xg_tag_map(MyFormat* instance, const QList<my_fun
  *
  */
 void xml_init(const QString& fname, QList<xg_tag_map_entry>* tbl, const char* encoding,
-              const char** ignorelist = nullptr,
-              const char** skiplist = nullptr, bool dynamic_tbl = false);
+              const char* const* ignorelist = nullptr,
+              const char* const* skiplist = nullptr, bool dynamic_tbl = false);
 void xml_init(const QString& fname, xg_tag_mapping* tbl,const char* encoding,
-              const char** ignorelist = nullptr,
-              const char** skiplist = nullptr);
+              const char* const* ignorelist = nullptr,
+              const char* const* skiplist = nullptr);
 void xml_read();
 void xml_readstring(const char* str);
 void xml_readprefixstring(const char* str);