Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] Support for Elastic Cloud #155

Open
szaffarano opened this issue Nov 25, 2024 · 1 comment
Open

[FEAT] Support for Elastic Cloud #155

szaffarano opened this issue Nov 25, 2024 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@szaffarano
Copy link
Contributor

Describe the enhancement

Although building an elastic client for an ESS cluster is possible, the nodes must be configured manually (i.e., nodesSelector). The cloudId property provided by ESS has information about it, so that it's easier just to provide apiKey, apiSecret and cloudId to have a working client.

In a project, I've implemented an extension method for that. If you agree, I can submit the code.

Why is this needed?

Simplify the code

How do you think it should be done?

Already been implemented as an extension function, but it also could be implemented as a new KtorRestClient constructor

Will you be able to help with a pull request?

Yes!
@jillesvangurp
Copy link
Owner

Amazing. Please contribute this.

@jillesvangurp jillesvangurp added the help wanted Extra attention is needed label Dec 25, 2024
@jillesvangurp jillesvangurp mentioned this issue Dec 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@szaffarano @jillesvangurp