cli: add revsets.graph-prioritize setting #5627
Conversation
cli/src/commands/log.rs
Outdated
| @@ -147,6 +147,11 @@ pub(crate) fn cmd_log( | |||
| } | |||
| expression | |||
| }; | |||
| let prio_revset = settings | |||
| .get_string("revsets.log-graph-prioritize") | |||
| .optional()? | |||
There was a problem hiding this comment.
I think the default present(@) can be defined in config/revsets.toml.
Or do you want to set prioritized branch in addition to @? In that case, which revset should be displayed first? We might have to add a list of prioritized revsets.
There was a problem hiding this comment.
Good point, I originally tried adding it addition, but I don't think it made a big difference from my testing, and a single revset was always enough for me.
There was a problem hiding this comment.
Maybe it should just expect that the revset only contains a single revision. I'm not sure renderdag does much with multiple prioritizations, so usually coalesce(1, 2, 3) is what you want instead of 1 | 2 | 3.
Especially since the order of the revset is not defined.
There was a problem hiding this comment.
Maybe it should just expect that the revset only contains a single revision.
Yes, the set size should usually be 0 or 1, but I wouldn't add extra check for that.
We might want to add some sorting or ordered union revset functions that can be used only in certain context, but I'm not sure.
jakobhellermann
force-pushed
the
revset-prioritize
branch
from
bfe80b2 to
de6aedf
Compare
fixes #5506
I've been using this for a while now, using
where
devis my megamerge. I've found it to increase the readability of the graph by quite a lot.Before:
After:
Checklist
If applicable:
CHANGELOG.md^ not yet
also I'm gonna write a better commit message