GPG signing silently fails on incorrect settings

[PerchunPak]

Description

For some reason, GPG signing doesn't work for me. If I do a commit using jj and then do git log --show-signatures, there are no signatures. GitHub also doesn't see my signature.

Steps to Reproduce the Problem

https://asciinema.org/a/q7t4a2003pIMKbwC7VEC6fIFD

jj sign from #4747 https://asciinema.org/a/dYHq59eXmgxW4TOYQ9ipNLMBD

Expected Behavior

$ git log --show-signatures -1
────────────────────────────────────────────────┐
commit 12da68c03b11c2be6776941f00da6aa043bb2b92 │
────────────────────────────────────────────────┴
gpg: Signature made Tue 04 Feb 2025 07:01:35 AM CET
gpg:                using RSA key BBB51142959D8549A3D2F6C5313F67D1EAB770F9
gpg: Good signature from "Perchun Pak <[email protected]>" [unknown]
gpg: WARNING: This key is not certified with a trusted signature!
gpg:          There is no indication that the signature belongs to the owner.
Primary key fingerprint: BBB5 1142 959D 8549 A3D2  F6C5 313F 67D1 EAB7 70F9
Author: PerchunPak <[email protected]>
Date:   Tue Feb 4 07:01:35 2025 +0100

    test

Actual Behavior

No signature present

Specifications

• Platform: NixOS unstable
• Version: 0.25.0, ebac2b8, Implement jj sign and jj unsign commands #4747 rebased onto ebac2b8

[bnjmnt4n]

Can you confirm that you've correctly set the required settings: https://jj-vcs.github.io/jj/latest/config/#gnupg-signing? Posting your configuration would be helpful for debugging.

[PerchunPak]

my ~/.config/jj/config.toml

[core]
fsmonitor = "watchman"

[core.watchman]
register_snapshot_trigger = true

[signing]
key = "313F67D1EAB770F9"
sign-all = true

[user]
email = "[email protected]"
name = "PerchunPak"

$ jj config
operation.hostname = "perchun-laptop"
operation.username = "perchun"
ui.pager = "less"
ui.editor = "nvim"
core.fsmonitor = "watchman"
core.watchman.register_snapshot_trigger = true
signing.key = "313F67D1EAB770F9"
signing.sign-all = true
user.email = "[email protected]"
user.name = "PerchunPak"

[bnjmnt4n]

It looks like you're missing signing.backend = "gpg"?

[PerchunPak]

Oh, you're correct! I though gpg is the default value

It should not silently fail though (at least jj sign)

[pylbrecht]

It should not silently fail though (at least jj sign)

Very valid point. I will take care of that in #4747.