Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FR: Allow specifying tail for truncate_* template functions #5085

Open
zx8 opened this issue Dec 12, 2024 · 2 comments · May be fixed by #5584
Open

FR: Allow specifying tail for truncate_* template functions #5085

zx8 opened this issue Dec 12, 2024 · 2 comments · May be fixed by #5584
Labels
good first issue Good for newcomers polish🪒🐃 Make existing features more convenient and more consistent

Comments

@zx8
Copy link

zx8 commented Dec 12, 2024 •
edited
Loading

Describe the solution you'd like

This is a very minor nice-to-have, but would it be possible to add an optional tail to the truncate_* template functions, to indicate that truncation has occurred? Sometimes truncation occurs at a space character, and it's not obvious that there was a longer description available.

Describe alternatives you've considered

Currently, it's possible to do something like:

if(
  description.first_line().substr(0, 80).starts_with(description.first_line()),
  pad_end(80, description.first_line()),
  truncate_end(79, description.first_line()) ++ "…"
)

(After #5072 is released, I can replace this workaround with a length check)
@PhilipMetzger PhilipMetzger added good first issue Good for newcomers polish🪒🐃 Make existing features more convenient and more consistent labels Dec 12, 2024
@yuja
Copy link
Contributor

yuja commented Dec 13, 2024

fwiw, I would call the parameter as ellipsis or something, than fill_char. It shouldn't be repeated to fill the remaining space.

@zx8
Copy link
Author

zx8 commented Dec 13, 2024

https://docs.rs/console/latest/console/fn.truncate_str.html calls it tail - I think that's probably a better fit. Title updated.

@zx8 zx8 changed the title FR: Allow specifying fill_char for truncate_* template functions FR: Allow specifying tail for truncate_* template functions Dec 13, 2024
@bryceberger bryceberger mentioned this issue Dec 30, 2024
Open
3 tasks
steadmon added a commit to steadmon/jj that referenced this issue Feb 4, 2025
@steadmon
templater: add optional ellipsis arg to truncate template functions
1087a97 
If an ellipsis arg is given to the truncate_* template functions, append (or
prepend) the ellipsis when the template content is truncated to fit the maximum
width.

Fixes jj-vcs#5085.
steadmon added a commit that referenced this issue Feb 4, 2025
@steadmon
templater: add optional ellipsis arg to truncate template functions
e5652d0 
If an ellipsis arg is given to the truncate_* template functions, append (or
prepend) the ellipsis when the template content is truncated to fit the maximum
width.

Fixes #5085.
steadmon added a commit that referenced this issue Feb 4, 2025
@steadmon
templater: add optional ellipsis arg to truncate template functions
a3f623f 
If an ellipsis arg is given to the truncate_* template functions, append (or
prepend) the ellipsis when the template content is truncated to fit the maximum
width.

Fixes #5085.
@steadmon steadmon linked a pull request Feb 4, 2025 that will close this issue
Open
4 tasks
steadmon added a commit that referenced this issue Feb 5, 2025
@steadmon
templater: add optional ellipsis arg to truncate template functions
220a649 
If an ellipsis arg is given to the truncate_* template functions, append (or
prepend) the ellipsis when the template content is truncated to fit the maximum
width.

Fixes #5085.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers polish🪒🐃 Make existing features more convenient and more consistent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

templater: add optional ellipsis arg to truncate template functions jj-vcs/jj
3 participants
@yuja @zx8 @PhilipMetzger