Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Add support for season.nfo file creation #1152

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[FEATURE] Add support for season.nfo file creation #1152

wants to merge 3 commits into from

Conversation

Kamaroth92
Copy link

@Kamaroth92 Kamaroth92 commented Jan 9, 2025 •
edited
Loading

Fixes #1150

I am not much of a proper dev so please feel free to request changes

@Kamaroth92 Kamaroth92 mentioned this pull request Jan 9, 2025
Open
@jmbannon
Copy link
Owner

This looks great @Kamaroth92 ! A few asks

  1. Run make lint which should make that test go green
  2. Since we are changing the jellyfin prebuilt preset, we need to update the test fixtures to reflect the change. This can be done by setting https://github.com/jmbannon/ytdl-sub/blob/master/tests/resources.py#L6 to True and running them. If needed, I'd be happy to update PR with this

Thanks again and apologies for the delay in reviewing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for season.nfo in collections for Emby
2 participants
@Kamaroth92 @jmbannon