Restoring Backup Misplaces Custom Tags

[nopeha]

Steps to reproduce

1. Create and Restore Backup from one Library (first device) in a second Library (empty Library/second device)
2. Check the tags of some entries in the second Library.
3. In the second Library, custom tags on some entries they shouldn't be on, appearing to be mixed up with others. They do not mirror the tags on the entry in the original device/library.

Example:
Phone (original library/device one)

Tablet (library populated by backup)

Expected behavior

The tags should match between the original library and the new library.

Actual behavior

The tags do not always match. I had this issue appear on more than one backup, and the entries having the issue changed each time.

Crash logs

No response

Tachiyomi version

1.9.3 (both devices)

Android version

Android 12 (both devices)

Device

Samsung Galaxy S10 & Samsung Galaxy Tab 6

Other details

I believe this to be an issue with the backup file itself. I don't know enough about the coding of the backup, however through testing that seems to be the main constant in the situation.

Acknowledgements

• I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
• This is a TachiyomiSY specific issue that does not happen in Tachiyomi Preview.
• I have written a short but informative title.
• If this is an issue with an extension, I should be opening an issue in the extensions repository.
• I have gone through the FAQ and troubleshooting guide.
• I have updated the app to version 1.9.3.
• I have updated all installed extensions.
• I will fill out all of the requested information in this form.

[jobobby04]

Can you show a screenshot with the edit info dialog open, as well as can you try to reproduce it with the next build?

[nopeha]

(Sorry about how late this is!)

I can do it for the next build; I use stable typically (where I found this issue). Should I try to use a backup on Preview for my tablet?

I tried a new backup and was met with the same issue, different entries each time get affected. I expanded of the information as well, see below. I only included screenshots from the backup I moved to the tablet I was using, as this is where the issues are. If you want screenshots from the device I created the backup on, please let me know. They do differ from these and are what the entries should look like.

I double checked and found it was across multiple sources that this issue was happening.

Suki na Ko ga Megane wo Wasureta - Tablet (Backup File)
Un-Expanded

Expanded

Edit Info

Suki na Ko ga Megane wo Wasureta - Phone (Original Device)
Un-Expanded

Expanded

Edit Info

***

Kin no Ito - Tablet (Backup File)
Un-Expanded

Expanded

Edit Info

Kin no Ito - Phone (Original Device)
Un-Expanded

Expanded

Edit Info

***

Goodbye, Daisy - Tablet (Backup File)
Un-Expanded

Expanded

Edit Info

Goodbye, Daisy - Phone (Original Device)
Un-Expanded

Expanded

Edit Info

***

Grancrest Senki - Tablet (Backup File)
Un-Expanded

Expanded

Edit Info

Grancrest Senki - Phone (Original Device)
Un-Expanded

Expanded

Edit Info

[nopeha]

I am unsure if you want me to make a new ticket or maybe rename this one, as I'm unsure if the two issues are related. I can tell they're both issues I have from backups, as I've had these issues over multiple backup files.

I discovered that the info box of at least one of my entries (Sandland) was absolutely wrong and I know I didn't edit any of the info. It's actually the info of a different entry (S Flower) I have in my library and I did edit both the description and the tags on that one. Funny enough, that S Flower didn't get any changes in its info.

Below is what SY from my backup shows me, what the original device shows me, and what the webview shows.

Incorrect Information & Entry:
Sandland - Tablet (Backup File)
Un-Expanded

Expanded

Edit Info

S Flower - Tablet (Backup File)
I couldn't get the cover image for this one due to a Cloudflare issue.
Un-Expanded

Expanded

Edit Info

***
Correct Information & Entry:
Sandland - Phone (Original Device)
Un-Expanded

Expanded

Edit Info

S Flower - Phone (Original Device)
Un-Expanded

Expanded

Edit Info

***
Website of Entries:
Sandland - Website

S Flower - Website
I had Cloudflare issues and couldn't connect to the site, but the information on this library entry was added by me manually.

[LittleFreak]

In other forks, they don't get restored from backups at all.
I would've reported it earlier in the respective repo, but I've figured it's best to solve the problem here in this upstream instead. 🤔

[nopeha]

I've also come to realize that status was also affected in my backup. Some that should be "Ongoing" got switched to "Completed" -- I regularly have to manually change things to completed, but some are marked Completed in the backup when in the original device/library had it set to Ongoing.

Recap: sometimes tags, descriptions, status, etc. are taken from other entries in the backup files of my library. I cannot seem to find a reason why some connect to others and why it happens at random. It only seems to take things from my edits made from an entry, and if edits are made they and their original tags from the source go along with them to another library entry.

[jobobby04]

Going to assume this is fixed with the rewrites to backup handlers