fix: fixes casing of version strings #57
Open
+10
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an edge case in version string casing where the convert_case crate incorrectly transforms patterns like "v1" into "v_1" when converting cases. The fix uses a regular expression to normalize these patterns back to the expected format (e.g., "v_1" → "v1", "v_2" → "v2").
Key changes:
- Added regex pattern matching to detect and correct version string patterns in the
convert_case_filterfunction - Introduced
LazyLockfor efficient, thread-safe initialization of the regex pattern
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Addresses an edge case where the `convert_case` crate incorrectly transforms version strings like "v_1" into "V_1". This change introduces a regular expression to correct these patterns, ensuring that version strings are properly cased as "v1".
aorumbayev
force-pushed
the
fix/snake_case_edgecase
branch
from
f3e902f to
ca0a6b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses an edge case where the
convert_casecrate incorrectly transforms version strings like "v_1" into "V_1".This change introduces a regular expression to correct these patterns, ensuring that version strings are properly cased as "v1".
Noticed this as part of regenerating tests for algod in py utils, many tests with v2 prefix were generated with filenames where v_2 is split