Skip to content

Commit ea1ce10

Browse files
Timothy St. Clairbenh
Timothy St. Clair
authored andcommitted
Removal of python-boto from the repo and add configure checks.
Python boto exists on nearly all platforms that I can think of. It makes sense to add the check to configure and remove from the repo. Review: https://reviews.apache.org/r/18910
1 parent 888fab4 commit ea1ce10

9 files changed

+53
-32
lines changed

3rdparty/Makefile.am

-3
Original file line numberDiff line numberDiff line change
@@ -32,20 +32,17 @@ CONFIGURE_ARGS = @CONFIGURE_ARGS@ --enable-shared=no --with-pic --srcdir=.
3232

3333
include versions.am
3434

35-
BOTO = boto-$(BOTO_VERSION)
3635
DISTRIBUTE = distribute-$(DISTRIBUTE_VERSION)
3736
LEVELDB = leveldb
3837
ZOOKEEPER = zookeeper-$(ZOOKEEPER_VERSION)
3938

4039

4140
EXTRA_DIST = \
42-
$(BOTO).zip \
4341
$(DISTRIBUTE).tar.gz \
4442
$(LEVELDB).tar.gz \
4543
$(ZOOKEEPER).tar.gz
4644

4745
CLEAN_EXTRACTED = \
48-
$(BOTO) \
4946
$(DISTRIBUTE) \
5047
$(LEVELDB) \
5148
$(ZOOKEEPER)

3rdparty/boto-2.0b2.zip

-378 KB
Binary file not shown.

3rdparty/versions.am

-1
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,5 @@
1919
# third-party packages in exactly one place. For now, however, we
2020
# still need to update version numbers in src/python/setup.py.in too!
2121

22-
BOTO_VERSION = 2.0b2
2322
DISTRIBUTE_VERSION = 0.6.26
2423
ZOOKEEPER_VERSION = 3.4.5

LICENSE

-25
Original file line numberDiff line numberDiff line change
@@ -239,31 +239,6 @@ FOR ANY DAMAGES OR OTHER LIABILITY, WHETHER IN CONTRACT, TORT OR OTHERWISE,
239239
ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
240240
DEALINGS IN THE SOFTWARE.
241241

242-
243-
======================================================================
244-
For boto (3rdparty/boto-2.0b2.zip):
245-
======================================================================
246-
247-
Permission is hereby granted, free of charge, to any person obtaining a
248-
copy of this software and associated documentation files (the
249-
"Software"), to deal in the Software without restriction, including
250-
without limitation the rights to use, copy, modify, merge, publish, dis-
251-
tribute, sublicense, and/or sell copies of the Software, and to permit
252-
persons to whom the Software is furnished to do so, subject to the fol-
253-
lowing conditions:
254-
255-
The above copyright notice and this permission notice shall be included
256-
in all copies or substantial portions of the Software.
257-
258-
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
259-
OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABIL-
260-
ITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT
261-
SHALL THE AUTHOR BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
262-
WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
263-
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
264-
IN THE SOFTWARE.
265-
266-
267242
======================================================================
268243
For distribute-0.6.26 (3rdparty/distribute-0.6.26.tar.gz):
269244
======================================================================

configure.ac

+7-1
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ AC_CONFIG_COMMANDS_POST([ac_configure_args="$ac_configure_args_post"])
7676

7777
AC_CONFIG_SUBDIRS([3rdparty/libprocess])
7878

79-
AC_CONFIG_FILES([Makefile])
79+
AC_CONFIG_FILES([Makefile mesos.pc])
8080
AC_CONFIG_FILES([ec2/Makefile])
8181
AC_CONFIG_FILES([src/Makefile])
8282
AC_CONFIG_FILES([3rdparty/Makefile])
@@ -587,6 +587,12 @@ There are two possible workarounds for this issue:
587587

588588
AC_DEFINE([MESOS_HAS_PYTHON])
589589

590+
AC_PYTHON_MODULE([boto], [no],
591+
AC_MSG_WARN([can not find python-boto
592+
-------------------------------------------------------------------
593+
mesos-ec2 services will not function.
594+
-------------------------------------------------------------------]))
595+
590596
has_python=yes
591597
fi
592598

docs/getting-started.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ There are different ways you can get Mesos:
3333
$ sudo apt-get install openjdk-6-jdk
3434

3535
# Install devel python.
36-
$ sudo apt-get install python-dev
36+
$ sudo apt-get install python-dev python-boto
3737

3838
# Install devel libcurl
3939
$ sudo apt-get install libcurl4-nss-dev

ec2/mesos-ec2

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,4 +17,4 @@
1717
# limitations under the License.
1818

1919
cd "`dirname $0`"
20-
PYTHONPATH="$PYTHONPATH:../third_party/boto-2.0b2.zip/boto-2.0b2" python ./mesos_ec2.py $@
20+
python ./mesos_ec2.py $@

m4/ac_python_module.m4

+31
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
1+
dnl @synopsis AC_PYTHON_MODULE(modname[, fatal])
2+
dnl
3+
dnl Checks for Python module.
4+
dnl
5+
dnl If fatal is non-empty then absence of a module will trigger an
6+
dnl error.
7+
dnl
8+
dnl @category InstalledPackages
9+
dnl @author Andrew Collier <[email protected]>.
10+
dnl @version 2004-07-14
11+
dnl @license AllPermissive
12+
13+
AC_DEFUN([AC_PYTHON_MODULE],[
14+
AC_MSG_CHECKING(python module: $1)
15+
python -c "import $1" 2>/dev/null
16+
if test $? -eq 0;
17+
then
18+
AC_MSG_RESULT(yes)
19+
eval AS_TR_CPP(HAVE_PYMOD_$1)=yes
20+
else
21+
AC_MSG_RESULT(no)
22+
eval AS_TR_CPP(HAVE_PYMOD_$1)=no
23+
24+
$3
25+
26+
if test "$2" = "yes"; then
27+
AC_MSG_ERROR(failed to find required module $1)
28+
exit 1
29+
fi
30+
fi
31+
])

mesos.pc.in

+13
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
################################
2+
# Pkg-Config file for mesos #
3+
################################
4+
5+
Name: mesos
6+
Description: Cluster manager for sharing distributed application frameworks
7+
URL: http://mesos.apache.org/
8+
Version: @VERSION@
9+
10+
prefix=@prefix@
11+
exec_prefix=@exec_prefix@
12+
includedir=@includedir@
13+
libdir=@libdir@

0 commit comments

Comments
 (0)