Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update base image to Alpine 3.21 #968

Open
2 of 4 tasks
vladaurosh opened this issue Jan 20, 2025 · 1 comment
Open
2 of 4 tasks

Update base image to Alpine 3.21 #968

vladaurosh opened this issue Jan 20, 2025 · 1 comment
Labels
Feature request➕ New feature or request next release/in dev image🚀 This is coming in the next release or was already released if the issue is Closed.

Comments

@vladaurosh
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing open and closed issues

Is your feature request related to a problem? Please describe

Hey @jokob-sk
It's time to move to Alpine 3.21 :D

There's an issue with netifaces, it's abandoned project amd fork netifaces-plus is having the same issue compiling.

      netifaces.c:1808:9: error: initialization of 'int' from 'void *' makes integer from pointer without a cast [-Wint-conversion]
       1808 |         NULL,
            |         ^~~~
      netifaces.c:1808:9: note: (near initialization for 'msghdr.__pad1')
      netifaces.c:1843:33: warning: comparison of integer expressions of different signedness: '__u32' {aka 'unsigned int'} and 'int' [-Wsign-compare]
       1843 |         if (pmsg->hdr.nlmsg_seq != seq || pmsg->hdr.nlmsg_pid != sanl.nl_pid)
            |                                 ^~
      error: command '/usr/bin/gcc' failed with exit code 1
      [end of output]

But luckily there's netifaces2 that should work fine.
https://pypi.org/project/netifaces2/

@jokob-sk would you be able to test with Alpine 3.21 and netifaces2?

Describe the solution you'd like

N/A

Describe alternatives you've considered

N/A

Anything else?

N/A

Am I willing to test this? 🧪

  • I will do my best to test this feature on the netlertx-dev image when requested within 48h and report bugs to help deliver a great user experience for everyone and not to break existing installations.

Can I help implement this? 👩‍💻👨‍💻

  • Yes
  • No
@vladaurosh vladaurosh added the Feature request➕ New feature or request label Jan 20, 2025
jokob-sk pushed a commit that referenced this issue Jan 20, 2025
@jokob-sk
Copy link
Owner

Thanks for keeping my base image updated :)

Just pushed to dev - should be ready in 15 min. - would be great if you could click around (looks good to me though). netifaces was only use din the omada plugin, but the import was commented out, so removed it completely.

@jokob-sk jokob-sk added the next release/in dev image🚀 This is coming in the next release or was already released if the issue is Closed. label Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request➕ New feature or request next release/in dev image🚀 This is coming in the next release or was already released if the issue is Closed.
Projects
None yet
Development

No branches or pull requests

2 participants