Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apostrophe not allowed in device's name #995

Open
3 of 7 tasks
vladaurosh opened this issue Feb 14, 2025 · 4 comments
Open
3 of 7 tasks

Apostrophe not allowed in device's name #995

vladaurosh opened this issue Feb 14, 2025 · 4 comments
Labels
bug 🐛 Something isn't working next release/in dev image🚀 This is coming in the next release or was already released if the issue is Closed.

Comments

@vladaurosh
Copy link
Contributor

Is there an existing issue for this?

The issue occurs in the following browsers. Select at least 2.

  • Firefox
  • Chrome
  • Edge
  • Safari (unsupported) - PRs welcome
  • N/A - This is an issue with the backend

Current Behavior

Looks like apostrophe is not allowed anymore in device's name, and previously it was (I have some devices with ' in name).

Expected Behavior

Allow ' in device's name.

Steps To Reproduce

Change name of device to consist ' in the name.
Save.
No errors but after saving, ' is lost.

app.conf

docker-compose.yml

What installation are you running?

Production (netalertx)

app.log

No response

Debug enabled

  • I have read and followed the steps in the wiki link above and provided the required debug logs and the log section covers the time when the issue occurs.
@vladaurosh vladaurosh added the bug 🐛 Something isn't working label Feb 14, 2025
@jokob-sk
Copy link
Owner

Hi @vladaurosh ,

That's by design as not to break SQL queries. I tried HTML encoding it, but it would require fixes in a lot of locations. Do you have a suggestion on a compromise? Maybe another character replacement?

@jokob-sk jokob-sk added the Waiting for reply⏳ Waiting for the original poster to respond, or discussion in progress. label Feb 14, 2025
@vladaurosh
Copy link
Contributor Author

Hey @jokob-sk
No worries than, it's not a big deal at all. I thought it was a bug since previously you could use apostrophe character.
This ticker can be closed.

@jokob-sk
Copy link
Owner

@vladaurosh - actually I've found an apostrophe character that can be used. Will be available in the next release.

@jokob-sk jokob-sk added next release/in dev image🚀 This is coming in the next release or was already released if the issue is Closed. and removed Waiting for reply⏳ Waiting for the original poster to respond, or discussion in progress. labels Feb 15, 2025
@vladaurosh
Copy link
Contributor Author

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working next release/in dev image🚀 This is coming in the next release or was already released if the issue is Closed.
Projects
None yet
Development

No branches or pull requests

2 participants