Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: check that all banked functions are defined correctly #100

Closed
2 tasks done
jorgegv opened this issue Sep 29, 2022 · 1 comment
Closed
2 tasks done

build: check that all banked functions are defined correctly #100

jorgegv opened this issue Sep 29, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@jorgegv
Copy link
Owner

jorgegv commented Sep 29, 2022

Functions that are migrated to banked_code directory need to have 3 definitions:

  • Add a new ID macro for the function to memory.h
  • Add its new function call macro to memory.h
  • Add its ID to 00main.asm table so that the memory_call_banked_function... functions can find the banked functions

The build process needs to check that each banked function is defined correctly in all places, because in several ocassions some of the steps were forgotten and it led to long debugging times until I noticed the missing step.

Tasks:

  • Create a script that checks that banked functions are defined fully and correctly
  • Integrate that script in the build process (Makefile ) so that build fails if any banked function is not correctly defined
@jorgegv jorgegv added the enhancement New feature or request label Sep 29, 2022
@jorgegv jorgegv added this to the Release 0.6.0 milestone Sep 29, 2022
@jorgegv jorgegv self-assigned this Sep 29, 2022
@jorgegv
Copy link
Owner Author

jorgegv commented Sep 29, 2022

merged in 277a488

@jorgegv jorgegv closed this as completed Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant