Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inferring dates fails for text containing [] and - leading to a ValueError on line 186 of chatparsers.py #135

Closed
osiloke opened this issue Apr 22, 2024 · 1 comment · Fixed by #136
Closed

Inferring dates fails for text containing [] and - leading to a ValueError on line 186 of chatparsers.py #135

osiloke opened this issue Apr 22, 2024 · 1 comment · Fixed by #136
Labels
bug Something isn't working parsers Issue regarding the parsers

Comments

@osiloke
Copy link

osiloke commented Apr 22, 2024

Sample Whatsapp message

08/04/2022, 16:40 - +234 700 000 0000: ```
[2,4,0,4,11,2602,36] -> 11
[160,3,1719,19,13,-21] -> 160
@joweich joweich mentioned this issue Apr 22, 2024
Merged
@joweich joweich added bug Something isn't working parsers Issue regarding the parsers labels Apr 22, 2024
@joweich
Copy link
Owner

joweich commented Apr 22, 2024

Hey @osiloke, thank you for raising this!
I drilled down this issue in the regex that identifies if a line is the start of a new message.
Your line

[160,3,1719,19,13,-21] -> 160

matches our regex pattern.
This is clearly a bug that I fixed in #136. Would you mind validating the fix before I merge it and release a new version accordingly? Thank you!! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working parsers Issue regarding the parsers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[FIX] Restrict end of regex to prevent matches with non-date strings joweich/chat-miner
2 participants
@osiloke @joweich