New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy and paste error in `lock()`? #10

Open

orestisfl opened this issue Jun 24, 2024 · 0 comments

orestisfl commented Jun 24, 2024

k8slock/locker.go

Lines 187 to 192 in 6f294b1

    
           lease.Spec.HolderIdentity = pointer.String(l.clientID) 
        
           if lease.Spec.LeaseTransitions != nil { 
        
           	lease.Spec.LeaseTransitions = pointer.Int32((*lease.Spec.LeaseTransitions) + 1) 
        
           } else { 
        
           	lease.Spec.LeaseTransitions = pointer.Int32((*lease.Spec.LeaseTransitions) + 1) 
        
           }

Here, the code checks if lease.Spec.LeaseTransitions is nil but the if-else branches are identical.

pointer.Int32((*lease.Spec.LeaseTransitions) + 1)

will segfault with a nil lease.Spec.LeaseTransitions

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment