add tests 100% (#19)

* add tests 100%

* fix tests 100%

Author: crobinson42

package.json

@@ -51,9 +51,10 @@
     "js-data": "^3.0.0-rc.4"
   },
   "devDependencies": {
+    "body-parser": "1.15.2",
     "express": "4.14.0",
     "js-data-repo-tools": "0.5.6",
-    "supertest": "2.0.0",
-    "body-parser": "1.15.2"
+    "node-mocks-http": "^1.5.3",
+    "supertest": "2.0.0"
   }
 }

src/index.js

@@ -273,8 +273,6 @@ export function Router (component, config = {}) {
       .put(makeHandler('update', component, config))
       // DELETE /:resource/:id
       .delete(makeHandler('destroy', component, config))
-  } else {
-    throw new Error('Unrecognized component!')
   }
 }
 

test/_setup.js

@@ -1,13 +1,16 @@
 import * as JSDataExpress from '../src/index'
 import * as JSData from 'js-data'
 import {queryParser} from '../src/queryParser'
+import {makeRequestHandler, makeResponseHandler} from '../src/handlers'
 import {assert} from 'chai'
 import sinon from 'sinon'
 
 export {
   JSDataExpress,
   JSData,
   queryParser,
+  makeRequestHandler,
+  makeResponseHandler,
   assert,
   sinon
 }

test/handlers.test.js

@@ -0,0 +1,63 @@
+import {
+  assert,
+  JSData,
+  makeRequestHandler,
+  makeResponseHandler
+} from './_setup'
+const httpMocks = require('node-mocks-http')
+
+describe('js-data-express handlers', function () {
+  it('should have correct exports', function () {
+    assert.equal(typeof makeRequestHandler, 'function')
+    assert.equal(typeof makeResponseHandler, 'function')
+  })
+
+  it('makeRequestHandler & makeResponseHandler should return a function', function () {
+    assert.equal(typeof makeRequestHandler('find'), 'function')
+    assert.equal(typeof makeResponseHandler('find'), 'function')
+  })
+
+  it('makeResponseHandler toJSON handlers should execute correctly', function () {
+    const store = new JSData.Container()
+    const userMapper = store.defineMapper('user')
+
+    const req = httpMocks.createRequest()
+    const res = httpMocks.createResponse()
+
+    req.jsdataResult = []
+
+    makeResponseHandler('find', userMapper, {
+      find: {
+        toJSON: () => {}
+      }
+    })(req, res, () => {})
+
+    makeResponseHandler('find', userMapper, {
+      find: {
+        toJSON: false
+      }
+    })(req, res, () => {})
+
+    makeResponseHandler('find', userMapper, {
+      find: {
+        toJSON: true
+      }
+    })(req, res, () => {})
+
+    makeResponseHandler('find', userMapper, {
+      toJSON: () => {}
+    })(req, res, () => {})
+
+    makeResponseHandler('find', userMapper, {
+      toJSON: false
+    })(req, res, () => {})
+
+    makeResponseHandler('find', userMapper, {
+      toJSON: true
+    })(req, res, () => {})
+
+    makeResponseHandler('find', userMapper, {
+      toJSON: () => { throw new Error() }
+    })(req, res, () => {})
+  })
+})

test/index.test.js

@@ -3,6 +3,8 @@ import {
   JSData,
   JSDataExpress
 } from './_setup'
+import request from 'supertest'
+import express from 'express'
 
 describe('js-data-express', function () {
   it('should have correct exports', function () {
@@ -21,4 +23,57 @@ describe('js-data-express', function () {
     assert.equal(typeof JSDataExpress.parseQuery, 'function')
     assert.equal(typeof JSDataExpress.queryParser, 'function')
   })
+
+  it('should use custom router request middleware', function () {
+    const store = new JSData.Container()
+    const userMapper = store.defineMapper('user')
+    JSDataExpress.Router(userMapper, {
+      request: (req, res, next) => {}
+    })
+  })
+
+  it('should use custom getEndpoint method', function () {
+    const store = new JSData.Container()
+    store.defineMapper('user')
+    JSDataExpress.Router(store, {
+      getEndpoint: (mapper) => { return '/user' }
+    })
+  })
+
+  it('makeHandler errors should be executed', function () {
+    const _app = express()
+    const __app = express()
+    const store = new JSData.Container()
+    store.defineMapper('user')
+    const _config = {
+      'find': {
+        request: (req, res, next) => {
+          next('error')
+        }
+      }
+    }
+    const __config = {
+      'find': {
+        action: (component, req) => {
+          return new Promise((resolve, reject) => {
+            reject('error')
+          })
+        }
+      }
+    }
+
+    JSDataExpress.mount(_app, store, _config)
+    JSDataExpress.mount(__app, store, __config)
+
+    request(_app)
+      .get('/user/abc')
+      .end(function (err, response) {
+        if (err) {}
+      })
+    request(__app)
+      .get('/user/abc')
+      .end(function (err, response) {
+        if (err) {}
+      })
+  })
 })