Skip to content

Commit 31f6cf1

Browse files
martinfrances107dawehner
authored andcommitted
#733 react-scripts: update to 3.0.1 (#734)
* #733 react-scripts: update to 3.0.1 * Removed deprecation notices associated history module. * linter improvements, requires some proptypes to be locked down. * eslint, requires fieldName to be corrected defined.
1 parent db57a6f commit 31f6cf1

File tree

6 files changed

+2506
-2515
lines changed

6 files changed

+2506
-2515
lines changed

demo/docroot/sites/default/default.settings.php

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -754,6 +754,15 @@
754754
*/
755755
$settings['entity_update_batch_size'] = 50;
756756

757+
/**
758+
* Entity update backup.
759+
*
760+
* This is used to inform the entity storage handler that the backup tables as
761+
* well as the original entity type and field storage definitions should be
762+
* retained after a successful entity update process.
763+
*/
764+
$settings['entity_update_backup'] = TRUE;
765+
757766
/**
758767
* Load local development override configuration, if available.
759768
*

packages/admin-ui/package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
"deepmerge": "^3.0.0",
2828
"downshift": "^3.1.4",
2929
"emotion": "^10.0.0",
30-
"history": "^4.7.2",
30+
"history": "^4.9.0",
3131
"interweave": "^9.2.1",
3232
"jss": "^9.8.2",
3333
"keycode": "^2.2.0",
@@ -65,7 +65,7 @@
6565
"chromedriver": "^2.45.0",
6666
"enzyme": "^3.3.0",
6767
"enzyme-adapter-react-16": "^1.1.1",
68-
"eslint": "5.6.0",
68+
"eslint": "5.16.0",
6969
"eslint-config-airbnb": "17.1.0",
7070
"eslint-config-prettier": "^3.1.0",
7171
"eslint-plugin-import": "^2.7.0",
@@ -76,7 +76,7 @@
7676
"nightwatch": "^1.0.16",
7777
"prettier": "^1.11.1",
7878
"react-axe": "^3.0.1",
79-
"react-scripts": "2.1.1",
79+
"react-scripts": "3.0.1",
8080
"react-test-renderer": "^16.6.3",
8181
"redux-saga-test-plan": "^3.6.0",
8282
"storybook": "^1.0.0",

packages/admin-ui/src/App.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
import React from 'react';
22
import PropTypes from 'prop-types';
33
import { Route, Switch, withRouter } from 'react-router-dom';
4-
import createBrowserHistory from 'history/createBrowserHistory';
4+
import { createBrowserHistory } from 'history';
5+
56
import deepMerge from 'deepmerge';
67
import { createStore, applyMiddleware, combineReducers } from 'redux';
78
import {

packages/components/src/Components/FormElements/InputCheckbox/InputCheckbox.js

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -142,25 +142,33 @@ const InputCheckbox = props => {
142142
};
143143

144144
InputCheckbox.propTypes = {
145+
checked: PropTypes.bool,
146+
145147
children: PropTypes.oneOfType([
146148
PropTypes.arrayOf(PropTypes.node),
147149
PropTypes.node,
148150
]).isRequired,
149151

150152
error: PropTypes.bool,
151153

154+
fieldName: PropTypes.string.isRequired,
155+
152156
htmlAttributes: PropTypes.objectOf([
153157
PropTypes.string,
154158
PropTypes.number,
155159
PropTypes.bool,
156160
]),
157161

162+
onChange: PropTypes.func,
163+
158164
required: PropTypes.bool,
159165
};
160166

161167
InputCheckbox.defaultProps = {
168+
checked: false,
162169
error: false,
163170
htmlAttributes: {},
171+
onChange: () => {},
164172
required: false,
165173
};
166174

packages/components/src/Components/FormElements/InputRadio/InputRadio.js

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -156,6 +156,8 @@ const InputRadio = props => {
156156
};
157157

158158
InputRadio.propTypes = {
159+
checked: PropTypes.bool,
160+
159161
/** Content contained within the label element. */
160162
children: PropTypes.oneOfType([
161163
PropTypes.arrayOf(PropTypes.node),
@@ -165,6 +167,8 @@ InputRadio.propTypes = {
165167
/** true if the label relates to an element with an error. */
166168
error: PropTypes.bool,
167169

170+
fieldName: PropTypes.string.isRequired,
171+
168172
/** Any additional HTML properties to add to the label element. */
169173
htmlAttributes: PropTypes.objectOf([
170174
PropTypes.string,
@@ -175,13 +179,17 @@ InputRadio.propTypes = {
175179
/** Content of the html "for" attribute to use for this label. */
176180
htmlFor: PropTypes.string.isRequired,
177181

182+
onChange: PropTypes.func,
183+
178184
/** True if this label relates to an element that is required. */
179185
required: PropTypes.bool,
180186
};
181187

182188
InputRadio.defaultProps = {
189+
checked: false,
183190
error: false,
184191
htmlAttributes: {},
192+
onChange: () => {},
185193
required: false,
186194
};
187195

0 commit comments

Comments
 (0)