New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect vector initializer #3

Open

huxingyi opened this issue Oct 19, 2018 · 0 comments

huxingyi commented Oct 19, 2018

Hi, very neat library! I am planning to use it in my modeling tool for fbx export.
I found a minor issue of values initializer, for example, here:

fbx/src/fbxproperty.cpp

Line 176 in 23d475a

    
           FBXProperty::FBXProperty(const std::vector<bool> a) : type('b'), values(a.size()) {

values is been initialized with a size, this will double the size of the vector. These values initializers should be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment