Merge pull request #405 from vlsi/apply_test

test: add test for applying org.jsonschema2dataclass before java plugin

Author: eirnym

src/main/kotlin/org/jsonschema2dataclass/js2p/Js2pPlugin.kt

@@ -7,6 +7,8 @@ import org.gradle.api.Task
 import org.gradle.api.file.DirectoryProperty
 import org.gradle.api.file.FileCollection
 import org.gradle.api.tasks.TaskProvider
+import org.gradle.kotlin.dsl.apply
+import org.gradle.kotlin.dsl.the
 import org.gradle.util.GradleVersion
 import org.jsonschema2dataclass.js2p.support.applyInternalAndroid
 import org.jsonschema2dataclass.js2p.support.applyInternalJava
@@ -33,21 +35,33 @@ class Js2pPlugin : Plugin<Project> {
 
         for (pluginId in listOf("java", "java-library")) {
             project.plugins.withId(pluginId) {
-                project.afterEvaluate {
-                    applyInternalJava(pluginExtension, project)
-                }
+                project.apply<Js2pJavaPlugin>()
             }
         }
         for (pluginId in androidPlugins) {
             project.plugins.withId(pluginId) {
-                project.afterEvaluate {
-                    applyInternalAndroid(pluginExtension, project)
-                }
+                project.apply<Js2pAndroidPlugin>()
             }
         }
     }
 }
 
+internal class Js2pJavaPlugin : Plugin<Project> {
+    override fun apply(project: Project) {
+        project.afterEvaluate {
+            applyInternalJava(the(), project)
+        }
+    }
+}
+
+internal class Js2pAndroidPlugin : Plugin<Project> {
+    override fun apply(project: Project) {
+        project.afterEvaluate {
+            applyInternalAndroid(the(), project)
+        }
+    }
+}
+
 internal fun setupConfigExecutions(
     extension: Js2pExtension,
     defaultSourcePath: Path?,

src/test/kotlin/org/jsonschema2dataclass/js2p/LateInitializationTest.kt

@@ -0,0 +1,45 @@
+package org.jsonschema2dataclass.js2p
+
+import org.gradle.testkit.runner.TaskOutcome
+import org.junit.jupiter.api.Assertions
+import org.junit.jupiter.api.DisplayName
+import org.junit.jupiter.api.io.TempDir
+import org.junit.jupiter.params.ParameterizedTest
+import org.junit.jupiter.params.provider.MethodSource
+import org.junit.jupiter.params.provider.NullSource
+import java.nio.file.Path
+
+class LateInitializationTest {
+    @TempDir
+    lateinit var testProjectDir: Path
+
+    @ParameterizedTest(name = "[{index}]({argumentsWithNames}) {displayName}")
+    @NullSource
+    @MethodSource("org.jsonschema2dataclass.js2p.TestGradleVersionHolder#gradleReleasesForTests")
+    @DisplayName("java-library applied after org.jsonschema2dataclass")
+    fun withoutExtension(gradleVersion: String?) {
+        writeBuildGradle(
+            testProjectDir,
+            """
+            plugins {
+                id 'org.jsonschema2dataclass'
+            }
+            // apply plugin: 'org.jsonschema2dataclass'
+            // Even though it is not recommended to use apply syntax, we use it here
+            // to ensure java-library plugin is applied after org.jsonschema2dataclass
+            apply plugin: 'java-library'
+            """.trimIndent()
+        )
+        copyAddressJSON(testProjectDir)
+
+        val result = executeRunner(gradleVersion, testProjectDir)
+
+        Assertions.assertEquals(TaskOutcome.SUCCESS, result.task(COLON_TASK_NAME0)?.outcome)
+        addressJavaExists(
+            testProjectDir,
+            TARGET_FOLDER_DEFAULT,
+            DEFAULT_EXECUTION_NAME,
+            PACKAGE_EMPTY
+        )
+    }
+}

src/test/kotlin/org/jsonschema2dataclass/js2p/PluginDslTest.kt

@@ -0,0 +1,14 @@
+package org.jsonschema2dataclass.js2p
+
+import org.gradle.kotlin.dsl.apply
+import org.gradle.testfixtures.ProjectBuilder
+import org.junit.jupiter.api.Test
+
+class PluginDslTest {
+    @Test
+    fun `plugin applies even without java plugin`() {
+        ProjectBuilder.builder().build().run {
+            apply(plugin = "org.jsonschema2dataclass")
+        }
+    }
+}

src/test/kotlin/org/jsonschema2dataclass/js2p/TestCasesGenerator.kt

@@ -1,5 +1,6 @@
 package org.jsonschema2dataclass.js2p
 
+import org.intellij.lang.annotations.Language
 import java.io.File
 import java.nio.file.Files
 import java.nio.file.Path
@@ -46,6 +47,10 @@ fun writeBuildFiles(testProjectDir: Path, shouldCopyAddressJSON: Boolean, suffix
     }
 }
 
+fun writeBuildGradle(testProjectDir: Path, @Language("Groovy") string: String) {
+    testProjectDir.resolve("build.gradle").toFile().writeText(string)
+}
+
 fun createBuildFilesSingleSimple(testProjectDir: Path, shouldCopyAddressJSON: Boolean) {
     writeBuildFiles(
         testProjectDir, shouldCopyAddressJSON,
@@ -122,7 +127,7 @@ fun createBuildFilesSingleSourceInherit(testProjectDir: Path, shouldCopyAddressJ
     Files.write(testProjectDir.resolve("settings.gradle"), ByteArray(0))
 }
 
-private fun copyAddressJSON(testProjectDir: Path) {
+internal fun copyAddressJSON(testProjectDir: Path) {
     val jsonDir = testProjectDir.resolve("src/main/resources/json")
     File(jsonDir.toString()).mkdirs()
     jsonDir.resolve("address.json").toFile().writeText(ADDRESS_JSON)