Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardizing our use of ctx #41

Open
jadeddelta opened this issue Jul 6, 2022 · 0 comments
Open

Standardizing our use of ctx #41

jadeddelta opened this issue Jul 6, 2022 · 0 comments
Labels
low priority Not necessary to work on now

Comments

@jadeddelta
Copy link
Contributor

Our code uses a bunch of ctx, whether it is updating the canvas, or drawing overlays on it. However, our usage of ctx varies heavily from place to place, using a very inconsistent combination of both this.ctx and canvas.getContext('2d'). This is partly a fault on TypeScript, as if canvas.getContext('2d') returns a ctx, then there's no way that it can return anything else unless a previous type of context was acquired from the ctx. I propose that eventually (definitely not right now), we should cleanup the code and decide how exactly we want to use this.ctx going forward.

@jadeddelta jadeddelta added the low priority Not necessary to work on now label Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low priority Not necessary to work on now
Projects
None yet
Development

No branches or pull requests

1 participant